-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs(config,plugins) type updates #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview is ready Built with commit 2ecad29 https://deploy-preview-3294--webpackjsorg-netlify.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have |
for union types in docs.
@@ -14,4 +15,4 @@ new webpack.WatchIgnorePlugin(paths); | |||
|
|||
## Options | |||
|
|||
- `paths` (array): A list of RegExps or absolute paths to directories or files that should be ignored | |||
- `paths` (`[string, RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `paths` (`[string, RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored | |
- `paths` (`[string | RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have a discussion on how to improve it outisde of this pr
Convert types to the ones defined in contribute section, also spotted missing examples and types in configuration section