search results link to right place

[niravasher]

Search results link to right place, not below. Closes #3366

[niravasher]

I don't understand why CI tests fail. Used --no-verify to commit. ESlint is present. someone please help

[niravasher]

@jamesgeorge007 @montogeek @EugeneHlushko what else is required to merge the PR? Please suggest required changes

[anikethsaha]

dont use --no-verify
resolve the linting issues locally
https://github.com/webpack/webpack.js.org/blob/master/package.json#L44-L49

[anikethsaha]

Please check the tests locally !!!!

[niravasher]

Sorry for the previous commit
While making changes in the Link/link.jsx file, react does not support DOM elements, hence I can't use window or document element directly.
So I did this

import React from 'react';
import ReactDOM from 'react-dom';
import { Link } from 'react-router-dom';
var createReactClass = require('create-react-class');

function offsetAnchor() {
  if(location.hash.length !== 0) {
    window.scrollTo(window.scrollX, window.scrollY - 100);
  }
}

var Box = createReactClass({
  componentDidMount: function() {
    document.addEventListener('hashchange', offsetAnchor);
    document.setTimeout(offsetAnchor, 1);
  }
});
ReactDOM.render(<Box />);

Build shows this error
ERROR in Invariant Violation: createClass(...): Class specification must implement a render method.
What should I do? @anikethsaha

[montogeek]

@anikethsaha No need to add 4 exclamation points to your comment.

[anikethsaha]

Sorry for the previous commit

Why sorry ?

@anikethsaha No need to add 4 exclamation points to your comment.

@montogeek I didnt get this, does having 4 exclamation points mean something wrong ?
I am not getting the thing here.

[EugeneHlushko]

@anikethsaha it looks like an order or in a command tone, i suggest you keep it friendly and rather advise or suggest, e.g. I would suggest you run the tests locally before requesting reviews to save both yours and reviewers time.

If i would apply the same technique you've used there, my suggestion would also look rude:
Stop giving orders to contributors @anikethsaha !

[EugeneHlushko]

I see what you are trying to achieve but technique used is static (100px), there is another PR trying to solve this with CSS, which is preferable to this snippet ( i dont remember # of the PR, please check it out in the list of recent PRs ) and maybe contribute there

[anikethsaha]

@anikethsaha it looks like an order or in a command tone, i suggest you keep it friendly and rather advise or suggest, e.g. I would suggest you run the tests locally before requesting reviews to save both yours and reviewers time.

I am sorry , i kind of have a habit of using ! frequently not just in GitHub but in other platforms as well.
I will try to change my commenting style

If i would apply the same technique you've used there, my suggestion would also look rude:
Stop giving orders to contributors @anikethsaha !

I wasnt giving order . it was suggestion to fix the CI

[EugeneHlushko]

This was fixed via css