This repository was archived by the owner on Jun 4, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows to load bookmarks when they change, load Favicons with bookmarks
…opdown, fix dropdown positioning, add higher pisel-density default icons
sentialx
reviewed
May 1, 2020
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a bookmark bar in wexond. It can be opened via the settings page, the window menu under bookmarks, or with the shortcut CmdOrCtrl+Shift+B.
This PR also changes the behavior of setting the height of the page BrowserView. Due to the fact that the height of the toolbar is now dynamic, the toolbar height is measured and used as the offset. The Window also watches the height of the toolbar and adjusts the BrowserView height to reflect the correct height whenever the toolbar height changes.
In addition, this PR fixes several current issues with bookmarks:
order
valueThere are still a couple of limitation with the implementation of bookmarks in wexond:
Notes: Added bookmark bar.