Skip to content

webkit-prefixed pseudo-elements are always treated valid in WebKit and Blink #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miketaylr opened this issue Jul 11, 2018 · 16 comments
Closed

Comments

@miketaylr
Copy link
Member

The data is now showing ~40% of page loads have unknown -webkit pseudo elements from the Chrome use counter, which is a significant proportion.

w3c/csswg-drafts#2156 (comment)

@miketaylr
Copy link
Member Author

@upsuper
Copy link
Member

upsuper commented Aug 24, 2018

Note for the spec: Blink seems to lowercase the pseudo-element string. This behavior should probably also be put into the spec if we going to do that.

@annevk
Copy link
Member

annevk commented Aug 24, 2018

For the purposes of selectorText you mean? Does it only do that for prefixed pseudo-elements or all of them?

@fantasai @tabatkins it seems we should put this "always treat webkit-prefixed pseudo-elements as valid" straight into the Selectors specification, no?

@upsuper
Copy link
Member

upsuper commented Aug 24, 2018

FWIW, several a new web-platform test for this is being added in web-platform-tests/wpt#12673.

@miketaylr
Copy link
Member Author

it seems we should put this "always treat webkit-prefixed pseudo-elements as valid" straight into the Selectors specification, no?

+1, if possible.

@tabatkins
Copy link
Contributor

Sigh, yeah.

@tabatkins
Copy link
Contributor

@annevk
Copy link
Member

annevk commented Aug 24, 2018

@tabatkins cool, thanks. Where is serializing of selectors defined?

@tabatkins
Copy link
Contributor

@miketaylr
Copy link
Member Author

Assuming that sticks, looks like we can close here. Thanks everyone!

@annevk
Copy link
Member

annevk commented Aug 25, 2018

I think the serializing definition needs to be updated as these prefixed pseudo-elements get lowercased (not defined).

I also wonder if since they are not technically psuedo-elements some other language needs to be added, but maybe it's okay.

@annevk annevk reopened this Aug 25, 2018
@tabatkins
Copy link
Contributor

I think the serializing definition needs to be updated as these prefixed pseudo-elements get lowercased (not defined).

CSSOM needs to define in general that pseudo-class/element names are lowercased; these specific pseudos aren't special in that regard. (See http://software.hixie.ch/utilities/js/live-dom-viewer/saved/6160.) So that's an issue on OM, but nothing that should stop this specific issue from closing.

I also wonder if since they are not technically psuedo-elements some other language needs to be added, but maybe it's okay.

We don't care what they are in the tree (which is "nothing"), we care about what they are in the context of Selectors, which is definitely "pseudo-element selectors". No new terminology needs to be added.

@annevk
Copy link
Member

annevk commented Aug 27, 2018

@tabatkins I don't think element names are lowercased? And for pseudo-elements it's not a problem at the moment I think, as it says to return the name of the pseudo-element, which is always in lowercase in the specifications.

@tabatkins
Copy link
Contributor

Sorry, by "pseudo-class/element" I was distributing the "pseudo-" over the slash; I was referring to pseudo-elements, not regular elements. ^_^

I see what you mean about needing to specify lowercasing, tho.

@tabatkins
Copy link
Contributor

And I've gone ahead and specified the serialization behavior in Selectors, since this is the only place that needs special handling.

So you can go ahead and re-close this now, @annevk.

@annevk
Copy link
Member

annevk commented Aug 30, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants