Skip to content

-webkit-image-set() might be a requirement to be compatible. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlcow opened this issue May 5, 2021 · 6 comments
Closed

-webkit-image-set() might be a requirement to be compatible. #144

karlcow opened this issue May 5, 2021 · 6 comments

Comments

@karlcow
Copy link
Member

karlcow commented May 5, 2021

GitHub shows some usage of -webkit-image-set() only

@karlcow
Copy link
Member Author

karlcow commented May 5, 2021

@foolip
Copy link
Member

foolip commented May 6, 2021

Looks like the spec for this is https://drafts.csswg.org/css-images-4/#image-set-notation.

Should the prefixed variant be defined to behave exactly the same, or are there differences? @schenney-chromium do you know?

@schenney-chromium
Copy link

We would have a long road to remove the prefixed version because it is used in many Chrome and ChromeOS UI pages. Any change short of removing would also be challenging.

Fortunately, based on my understand of the parsing code and the spec, the -webkit-image-set spec is a syntactically valid subset of the image-set spec and the spec gives us a lot of scope in how to decide which image to use. So I don't see a need to adjust any spec based on back-compat and the implementation of image-set will be somewhat easier.

@emilio
Copy link

emilio commented May 12, 2021

I think w3c/csswg-drafts#6285 is the most trivial way to go forward with this in terms of complexity of both specifications and implementations.

moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 12, 2021
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709415
gecko-commit: 01bca848cb09b426c0c1c5f34d32dbe3fa5b9aa7
gecko-reviewers: karlcow, twisniewski
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 12, 2021
…e-set(). r=karlcow,twisniewski

The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 12, 2021
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709415
gecko-commit: 01bca848cb09b426c0c1c5f34d32dbe3fa5b9aa7
gecko-reviewers: karlcow, twisniewski
@gsnedders
Copy link
Member

This can be closed, as w3c/csswg-drafts#6285 defined this in the CSS Images spec.

@miketaylr
Copy link
Member

Awesome.

Loirooriol added a commit to Loirooriol/servo that referenced this issue May 22, 2023
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912
Loirooriol pushed a commit to Loirooriol/servo that referenced this issue May 24, 2023
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912
Loirooriol pushed a commit to Loirooriol/servo that referenced this issue May 24, 2023
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

 * w3c/csswg-drafts#6285
 * whatwg/compat#144

Differential Revision: https://phabricator.services.mozilla.com/D114912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants