Dialog - RN63 broke Modal's onDismiss method, this fixes our API #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Nov 11, 2020
M-i-k-e-l
added a commit
that referenced
this pull request
Nov 23, 2020
* Dialog - RN63 broke Modal's onDismiss method, this fixes our API * Send onFadeDone only to iOS * Add a TODO (cherry picked from commit 7ee9fc1)
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 6, 2021
…-logic * master: Add missing functionality for Incubator.TextField (#1121) Update all app icons sizes for iOS project Adding 'defaultSource' for image source in case of an error (#1116) DateTimePicker - adding 'headerStyle' prop to adjust iOS dialog header style (#1117) add prepush script Infra/use did update (#1119) SettingsScreen - rename to UNSAFE (#1118) Create a middleware TextField migrator to migrate people to the new TextField implementation (#1113) Fix issue with missing selected indicator in Picker items (#1065) Fix issue for Android on rn63 - when passing null as tintColor to an image, the image is not displayed (#1055) Fix issue #1052 - PickerItem ignore renderItem prop (#1054) Dialog - RN63 broke Modal's onDismiss method, this fixes our API (#1026) pass containerStyle to checkbox when there's no label render checkbox container only if there's label (#1039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dialog - RN63 broke Modal's onDismiss method, this fixes our API
We're somewhat relying here on the fact that the fade animation takes longer (400) than the dismiss animation (300), although when I've tested it seemed to work with the same length on animation.
Changelog
Dialog - RN63 broke Modal's onDismiss method, this fixes our API