Add recent screens chips to our demo app for easy access #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Sep 23, 2024
demo/src/screens/SettingsScreen.js
Outdated
| @@ -3,7 +3,7 @@ import React, {Component} from 'react'; | |||
| import {StyleSheet, I18nManager} from 'react-native'; | |||
| import {Colors, View, Text, Picker, Incubator, Switch} from 'react-native-ui-lib'; //eslint-disable-line | |||
| import {navigationData} from './MenuStructure'; | |||
| import Storage, {DEFAULT_SCREEN, IS_RTL} from '../storage'; | |||
| import Storage, {DEFAULT_SCREEN, IS_RTL, AUTO_SET_DEFAULT} from '../storage'; | |||
There was a problem hiding this comment.
It's a little weird that there's a configuration that's not working; I understand it's for private, but still...
There was a problem hiding this comment.
I removed, I will add it only in private
I also clean up a little the settings screen
M-i-k-e-l
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add recent screens chips feature to our demo app for easy access
Changelog
Add recent screens chips feature to our demo app for easy access
Additional info