Skip to content

Fix sortable list components flexMigration #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix sortable list components flexMigration #3308

merged 1 commit into from
Oct 13, 2024

Conversation

ethanshar
Copy link
Collaborator

Description

Fix sortable list components flexMigration to use a container with flexGrow
Using flex caused issue when rendering the list in a specific layout with horizontal direction

<View flex>
  <View>
    <SortableList horizontal ...../>
  </View>
<View>

Changelog

Fix sortable list components flexMigration

Additional info

@ethanshar ethanshar requested a review from adids1221 October 13, 2024 07:48
@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Oct 13, 2024
adids1221
adids1221 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@adids1221 adids1221 merged commit 8f4a198 into master Oct 13, 2024
1 check passed
@adids1221 adids1221 deleted the fix/sortable_flex_migration branch October 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adids1221 adids1221 adids1221 approved these changes

Assignees

@adids1221 adids1221

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @adids1221