ColorPicker.Dialog exporting ColorPickerDialog #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Oct 28, 2024
src/components/colorPicker/index.tsx
Outdated
|
|
||
| export default asBaseComponent<Props>(ColorPicker); | ||
| export default asBaseComponent<Props, {Dialog: typeof ColorPickerDialog}>(ColorPicker); |
There was a problem hiding this comment.
Consider setting the static types like this (like we do in Button component)
ComponentStatics<typeof ColorPicker>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ColorPicker.DialogexportingColorPickerDialog.This export help us to use
ColorPickerDialogafter package build (usage for Doc's).Checked by
build:localpackage.Changelog
ColorPicker.DialogexportingColorPickerDialog.Additional info
None