Add useDebounce hook and timeoutOnChange for TextField #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Nov 8, 2024
| @@ -64,6 +64,7 @@ | |||
| }, | |||
| {"name": "validateOnStart", "type": "boolean", "description": "Should validate when the TextField mounts"}, | |||
| {"name": "validateOnChange", "type": "boolean", "description": "Should validate when the TextField value changes"}, | |||
| {"name": "timeoutOnChange", "type": "number", "description": "Add a debounce timeout when sending validateOnChange"}, | |||
There was a problem hiding this comment.
the name is misleading it sounds like it will debounce the onChange callback when typing
I would rename to validationDebounceTime
ethanshar
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add useDebounce hook and timeoutOnChange for TextField
Changelog
Add useDebounce hook
TextField - add timeoutOnChange to allow debouncing of error handling
Additional info
Ticket 4497