Skip to content

Fix/react native svg cssuri path #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Nov 16, 2024

Description

Fixed error when using ui-lib with react-native-svg version 14 and higher.

Changelog

Added support for react-native-svg 14 and higher.

Additional info

Breaking change - https://github.com/software-mansion/react-native-svg/releases/tag/v14.0.0

@nitzanyiz nitzanyiz requested a review from ethanshar November 18, 2024 15:10
@nitzanyiz nitzanyiz marked this pull request as ready for review November 18, 2024 15:10
@nitzanyiz nitzanyiz requested a review from M-i-k-e-l November 19, 2024 07:55
@nitzanyiz nitzanyiz assigned M-i-k-e-l and unassigned ethanshar Nov 19, 2024
@nitzanyiz nitzanyiz removed the request for review from ethanshar November 19, 2024 07:55
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update our usage of react-native-svg

@M-i-k-e-l M-i-k-e-l merged commit c6369d9 into master Nov 19, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the fix/react-native-svg-cssuri-path branch November 19, 2024 08:31
nitzanyiz added a commit that referenced this pull request Nov 19, 2024
* fixed optional dep CssUri

* make it more readable

* changed the way cssuri is exported so it won't trigger the error

* updated react-native-svg version to ^15.2.0

* updated react-native-svg version to 15.2.0 (exact)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants