Skip to content

TextField - ClearButton - fix right margin #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2025
Merged

TextField - ClearButton - fix right margin #3482

merged 2 commits into from
Jan 27, 2025

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

TextField - ClearButton - fix right margin with preset={'outline'}

To test use:

<TextField value={'Test '} showClearButton preset={'underline'}/>
<TextField value={'Test '} showClearButton preset={'outline'}/>

Changelog

TextField - ClearButton - fix right margin with preset={'outline'}

Additional info

See internal channel

@M-i-k-e-l M-i-k-e-l requested a review from Inbal-Tish January 12, 2025 14:54
Inbal-Tish
Inbal-Tish reviewed Jan 13, 2025
View reviewed changes
src/components/textField/index.tsx Outdated
onClear={onClear}
testID={`${props.testID}.clearButton`}
onChangeText={onChangeText}
preset={props.preset}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ClearButton component shouldn't be aware of the preset. I think we should pass 'style' instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Inbal-Tish Inbal-Tish assigned M-i-k-e-l and unassigned Inbal-Tish Jan 13, 2025
@M-i-k-e-l M-i-k-e-l assigned Inbal-Tish and unassigned M-i-k-e-l Jan 13, 2025
@M-i-k-e-l M-i-k-e-l requested a review from Inbal-Tish January 19, 2025 08:48
@Inbal-Tish Inbal-Tish merged commit a647cbb into master Jan 27, 2025
1 check passed
@Inbal-Tish Inbal-Tish deleted the fix/text-field-clear-button-right-margin branch January 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @Inbal-Tish