Picker - Fix wrong offset when items change from search

[nitzanyiz]

Description

Fixes bug where for some searched values in the Picker, the FlatList starts at an incorrect offset after the search. The FlatList items change, causing it to change its height and make it start the scroll at some negative offset. I've made it take the entire height that is left so this way the height will not change when the content changes so theres no jump.
I'm not sure if this is the correct solution. As it seems when the items change the FlatList goes under the TextInput, like having a negative offset so the picker item seems cut. After scrolling a little the item goes to its correct place and scroll resets correctly.

Steps to reproduce:

1. Open the modal
2. Search for Sh
3. "Shell" item should be cut

Playground to reproduce:

import React, {Component} from 'react';
import {View, Picker} from 'react-native-ui-lib';

const options = [
  {label: 'Rust', value: 'rust'},
  {label: 'Dart', value: 'dart'},
  {label: 'Elixir', value: 'elixir'},
  {label: 'Haskell', value: 'haskell'},
  {label: 'Clojure', value: 'clojure'},
  {label: 'Lua', value: 'lua'},
  {label: 'Erlang', value: 'erlang'},
  {label: 'F#', value: 'fsharp'},
  {label: 'MATLAB', value: 'matlab'},
  {label: 'Shell', value: 'shell'},
  {label: 'SAS', value: 'sas'},
  {label: 'Solidity', value: 'solidity'},
  {label: 'Smalltalk', value: 'smalltalk'},
  {label: 'Scheme', value: 'scheme'},
  {label: 'Scratch', value: 'scratch'}
];
export default class PlaygroundScreen extends Component {
  render() {
    return (
      <View flex paddingT-s4>
        <Picker
          showSearch
          label="Select a language"
          items={options}
        />
      </View>
    );
  }
}

Changelog

Picker - Fixes incorrect offset after search.

Additional info

MADS-4601

[Inbal-Tish]

You can simply name it _listProps instead of listPropsWithMergedStyles

[Inbal-Tish]

Nice. Left a supper small commnet