Skip to content

TabBar - Better accessibility roles and instructions #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 24, 2025
Merged

TabBar - Better accessibility roles and instructions #3501

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bda29ff
Added selected and tab accessibility role
nitzanyiz Feb 12, 2025
551cfa1
Update TODO comment in TabBar component for role change during React …
nitzanyiz Feb 12, 2025
d61a34b
Update TODO comment in TabBar component for clarity on role change du…
nitzanyiz Feb 12, 2025
e801a53
Fix setSelectedIndex call in TabController for improved index handling
nitzanyiz Feb 12, 2025
a74873a
Update accessibility role in TabBar component to 'tablist'
nitzanyiz Feb 12, 2025
934abaa
Merge branch 'master' into fix/TabBar-accessibilityRole
M-i-k-e-l Feb 18, 2025
c76a6ef
Fix accessibility role for TabBar component based on platform
nitzanyiz Feb 19, 2025
bf14f92
Merge branch 'master' into fix/TabBar-accessibilityRole
M-i-k-e-l Feb 19, 2025
a84c4c4
Refactor TabBar accessibility handling by removing selectedIndex stat…
nitzanyiz Feb 20, 2025
d78a0f9
Merge branch 'master' into fix/TabBar-accessibilityRole
M-i-k-e-l Feb 23, 2025
e4cee3e
Memoized accessibilityState
nitzanyiz Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update TODO comment in TabBar component for role change during React … 
…Native upgrade
  • Loading branch information
@nitzanyiz
nitzanyiz committed Feb 12, 2025
commit 551cfa1e266d310414112568498cce80afaeb874
2 changes: 1 addition & 1 deletion src/components/tabController/TabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ const TabBar = (props: Props) => {
onContentSizeChange={onContentSizeChange}
onLayout={onLayout}
>
{/* TODO: Might need to change role to tablist. Didn't work now when upgrading rn77 */}
{/* TODO: Might need to change role to tablist, when upgrading rn77, it didn't work now (rn73) */}
<View style={tabBarContainerStyle} accessibilityRole="tabbar" >{tabBarItems}</View>
{itemsCount > 1 && (
<Reanimated.View style={[styles.selectedIndicator, indicatorStyle, _indicatorTransitionStyle]}/>
Expand Down