Skip to content

feat(checkbox/radioButton): ensure minimum 48x48 hit target for better accessibility #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 3, 2025
Merged

feat(checkbox/radioButton): ensure minimum 48x48 hit target for better accessibility #3518

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
10c3c97
feat(checkbox/radioButton): ensure minimum 48x48 hit target for bette…
devin-ai-integration[bot] Feb 19, 2025
18aca35
refactor: destructure props at top of render functions
devin-ai-integration[bot] Feb 19, 2025
29c3852
fix: use destructured iconOnRight prop
devin-ai-integration[bot] Feb 19, 2025
9ce4651
refactor(checkbox/radioButton): move hitSlop calculation to dedicated…
devin-ai-integration[bot] Feb 19, 2025
e3f67db
fix(radioButton): revert iconOnRight prop destructuring
devin-ai-integration[bot] Feb 19, 2025
14921a6
fix(radioButton): revert iconOnRight prop destructuring changes
devin-ai-integration[bot] Feb 19, 2025
e5e72ff
fix(radioButton): only apply hitSlop to top and bottom
devin-ai-integration[bot] Feb 23, 2025
c7d9235
fix(radioButton): remove unused horizontalPadding variable
devin-ai-integration[bot] Feb 23, 2025
84eb5b9
refactor(checkbox): simplify hitSlop padding variable
devin-ai-integration[bot] Feb 23, 2025
d73d48e
Update src/components/checkbox/index.tsx
nitzanyiz Feb 24, 2025
f8133df
fix(checkbox): update getAccessibleHitSlop to accept size parameter
nitzanyiz Feb 26, 2025
2a1a3cf
Changed getAccessibleHitSlop to get size as argument
nitzanyiz Feb 26, 2025
3b19c50
Added gap to RadioGroup example to fit new hit target
nitzanyiz Feb 26, 2025
1413792
Merge remote-tracking branch 'origin' into devin/1739968065-checkbox-…
nitzanyiz Mar 3, 2025
4d29687
fix(checkbox): increase right margin for improved layout
nitzanyiz Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(radioButton): revert iconOnRight prop destructuring changes 
Co-Authored-By: [email protected] <[email protected]>
  • Loading branch information
@devin-ai-integration @nitzanyiz
devin-ai-integration[bot] and nitzanyiz committed Feb 19, 2025
commit 14921a6b92b896a21799e8b6ad59dd1208cf766f
2 changes: 1 addition & 1 deletion src/components/radioButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ class RadioButton extends PureComponent<Props, RadioButtonState> {
}

render() {
const {onPress, onValueChange, containerStyle, contentOnLeft, iconOnRight, ...others} = this.props;
const {onPress, onValueChange, containerStyle, contentOnLeft, ...others} = this.props;
const Container = onPress || onValueChange ? TouchableOpacity : View;

return (
Expand Down