Skip to content

Fix issue with hint targetFrame prop #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

Fix issue with hint targetFrame prop #3541

merged 3 commits into from
Mar 4, 2025

Conversation

ethanshar
Copy link
Collaborator

Description

Fix issue with Hint's targetFrame feature after recent refactor
Also, update the example demonstrating this feature

Changelog

Fix Hint's targetFrame position

Additional info

@ethanshar ethanshar requested a review from M-i-k-e-l February 27, 2025 11:55
@ethanshar ethanshar removed the request for review from M-i-k-e-l February 27, 2025 12:46
@ethanshar ethanshar assigned ethanshar and nitzanyiz and unassigned M-i-k-e-l and ethanshar Feb 27, 2025
M-i-k-e-l
M-i-k-e-l reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screen: I would change the Use random position to Use target frame (it's an option in the screen, it now has nothing to do with the name)

@M-i-k-e-l M-i-k-e-l requested a review from nitzanyiz February 27, 2025 16:49
@M-i-k-e-l M-i-k-e-l added the hotfix Requires a hotfix release label Feb 27, 2025
@nitzanyiz
Copy link
Collaborator

@ethanshar what was the bug here?

@ethanshar
Copy link
Collaborator Author

@ethanshar what was the bug here?

The bus was in one of the modules, someone use targetFrame prop to target a hint on the topbar area (which is not accessible as a component) and the hint had an offset due to extra calculations on our end
Our demo screen showcased this use case in a wrong way so I also fixed the example screen

@nitzanyiz nitzanyiz assigned ethanshar and unassigned nitzanyiz Mar 3, 2025
@ethanshar ethanshar assigned M-i-k-e-l and nitzanyiz and unassigned ethanshar Mar 4, 2025
@ethanshar ethanshar requested a review from M-i-k-e-l March 4, 2025 05:49
nitzanyiz
nitzanyiz reviewed Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@nitzanyiz nitzanyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@nitzanyiz nitzanyiz merged commit 80b4c9c into master Mar 4, 2025
1 check passed
@nitzanyiz nitzanyiz deleted the fix/hint_targetFrame branch March 4, 2025 08:32
M-i-k-e-l pushed a commit that referenced this pull request Mar 4, 2025
@ethanshar @M-i-k-e-l
Fix issue with hint targetFrame prop (#3541)
a44926e 
* Fix issue with hint targetFrame prop and change its example the example screen

* Fix TS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitzanyiz nitzanyiz nitzanyiz approved these changes

@M-i-k-e-l M-i-k-e-l Awaiting requested review from M-i-k-e-l

Assignees

@M-i-k-e-l M-i-k-e-l

@nitzanyiz nitzanyiz

Labels
hotfix Requires a hotfix release waiting-for-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethanshar @nitzanyiz @M-i-k-e-l