add ellipsizeMode prop for text truncation and improve accessibility #3542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adids1221 The ticket in the additional info is not correct, can you fix it? 🙏 |
fixed. |
nitzanyiz
reviewed
Mar 12, 2025
src/components/avatar/index.tsx
Outdated
| @@ -185,6 +187,7 @@ const Avatar = forwardRef<any, AvatarProps>((props: AvatarProps, ref: React.Forw | |||
| useAutoColors, | |||
| autoColorsConfig, | |||
| containerStyle, | |||
| ellipsizeMode = 'clip', | |||
There was a problem hiding this comment.
I think the prop name should be more informative on where it goes. Perhaps is better:
Suggested change
| ellipsizeMode = 'clip', | |
| labelEllipsizeMode = 'clip', |
src/components/avatar/index.tsx
Outdated
| @@ -354,7 +357,7 @@ const Avatar = forwardRef<any, AvatarProps>((props: AvatarProps, ref: React.Forw | |||
| > | |||
| <View testID={`${testID}.container`} style={textContainerStyle}> | |||
| {!_.isUndefined(text) && ( | |||
| <Text numberOfLines={1} style={textStyle} testID={`${testID}.label`}> | |||
| <Text numberOfLines={1} ellipsizeMode={ellipsizeMode} style={textStyle} testID={`${testID}.label`}> | |||
There was a problem hiding this comment.
Suggested change
| <Text numberOfLines={1} ellipsizeMode={ellipsizeMode} style={textStyle} testID={`${testID}.label`}> | |
| <Text numberOfLines={1} ellipsizeMode={labelEllipsizeMode} style={textStyle} testID={`${testID}.label`}> |
…wix/react-native-ui-lib into feat/Avatar_label_ellipsizeMode_support
|
Checked on Private with snapshot |
nitzanyiz
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avatar add
ellipsizeModeprop for text truncation and improve accessibility handeling.When using larger text on the device the label grow outside the container in some cases, we decided to remove the default
ellipsizeModeand set it toclip.Changelog
Avatar add
ellipsizeModeprop for text truncation and improve accessibility handeling.Additional info
MADS-4654