fix badge should be pimple when label undefined #3545
Conversation
|
@adids1221 some tests fail |
src/components/badge/index.tsx
Outdated
| const {size, label} = this.props; | ||
| return label === undefined ? 10 : size !== undefined ? size : 20; |
There was a problem hiding this comment.
You can make this last line more readable by setting a default value to size when destructing it
There was a problem hiding this comment.
I did a small refactor, when size is passed I expect the size to be the stronger prop.
I also moved the default pimple and badge sizes into a const I think it's more readable.
There was a problem hiding this comment.
That's an improvement and way more readable
Just double checking on what I wrote, can't we set the default size (DEFAULT_BADGE_SIZE) when destructing the size prop?
There was a problem hiding this comment.
Not, if we'll set size with default value it will always return the size and won't check if the label is undefined (since size is stronger then label)
Description
Badge should be pimple size when label undefined
Changelog
Fix Badge should be pimple size when label undefined
Additional info
MADS-4577