Avatar animate mode not supported on web #3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Mar 5, 2025
| @@ -287,7 +288,7 @@ const Avatar = forwardRef<any, AvatarProps>((props: AvatarProps, ref: React.Forw | |||
| const renderImage = () => { | |||
| if (source !== undefined) { | |||
| // Looks like reanimated does not support SVG | |||
| const ImageContainer = animate && !isSvg(source) ? AnimatedImage : Image; | |||
| const ImageContainer = animate && !isSvg(source) && !Constants.isWeb ? AnimatedImage : Image; | |||
There was a problem hiding this comment.
Let's also update in api.json about this prop that it's not supported on Web
There was a problem hiding this comment.
Fixed, missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AnimatedImage doesn't work on web platform.
When using animated Avatar we render AnimatedImage which doesn't work, for now when using web we will set animate to false to prevent Avatar not to render as expected.
snippet:
Changelog
Avatar with animated not supported on web.
Additional info
MADS-4577