Picker selection control bar and toggle all items functionality #3557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@M-i-k-e-l let's sync about the |
|
|
M-i-k-e-l
reviewed
Mar 16, 2025
…update related references
|
@M-i-k-e-l I removed the |
adids1221
commented
Mar 17, 2025
M-i-k-e-l
reviewed
Mar 18, 2025
|
@M-i-k-e-l the |
M-i-k-e-l
reviewed
Mar 23, 2025
M-i-k-e-l
reviewed
Mar 23, 2025
M-i-k-e-l
reviewed
Mar 23, 2025
M-i-k-e-l
reviewed
Mar 24, 2025
|
|
||
| export default function PickerSelectionStatusBar(props: PickerSelectionStatusProps) { | ||
| const {containerStyle, getLabel, showLabel = true} = props; | ||
| const context = useContext(PickerContext); | ||
| const {toggleAllItemsSelection, value = [], areAllItemsSelected} = context; | ||
| const _value: PickerMultiValue = value as PickerMultiValue; | ||
| const {toggleAllItemsSelection, selectedCount = 0, areAllItemsSelected} = context; |
There was a problem hiding this comment.
I don't think there should be a default value here
M-i-k-e-l
reviewed
Mar 24, 2025
|
|
||
| const checkboxIndeterminate = _value.length > 0 && !areAllItemsSelected; | ||
| const checkboxIndeterminate = !!selectedCount && !areAllItemsSelected; |
There was a problem hiding this comment.
I think selectedCount > 0 is more readable
M-i-k-e-l
approved these changes
Mar 24, 2025
adids1221
added a commit
that referenced
this pull request
Mar 31, 2025
* Picker selection control bar and toggle all items functionality * Refactor PickerScreen layout * Rename PickerSelectionControlBar to PickerSelectionStatusToolbar and update related references * Enhance selection status label functionality in PickerSelectionStatusToolbar * Refactor PickerSelectionStatusToolbar and types for improved selection handling * Remove 'none' option from select all types in Picker and update related types * Fix types issue in PickerItemsList * Refactor toggleAllItemsSelection and availableItems usage * Remove customLabel prop from PickerSelectionStatusProps * Add renderTopCustomElement and renderBottomCustomElement props to PickerSelectionStatusToolbar * Rename getLabel prop to getSelectionStatusLabe and update related usages * Refactor selectionStatus handling in PickerItemsList * Remove unnecessary null return in renderLabel * Remove renderTopCustomElement prop * Rename _onSegmentChange to onSegmentChange * Fix TypeScript ignore directive for selectAllType in Picker * Update buttonProps onPress parameter to use selectionValue and set default selectAllType to 'button' * Refactor Picker selection logic to use areAllItemsSelected and simplify selection status handling * Rename getSelectionStatusLabel to getLabel and update type definitions for clarity * Remove renderBottomCustomElement prop and add divider in PickerSelectionStatusToolbar * Refactor Picker component to remove PickerSelectAllType enum * Refactor PickerSelectionStatusToolbar to simplify props and selection handling * Rename PickerSelectionStatusToolbar to PickerSelectionStatusBar and update related references * Update buttonProps onPress to use customValue instead of selectionValue in PickerSelectionStatusBar * Add selectAllType prop to PickerSelectionStatusBar for flexible selection handling * Refactor PickerSelectionStatusBar to remove selectAllType prop and simplify selection handling * Fix type assertion for value in PickerSelectionStatusBar to ensure correct handling of PickerMultiValue * Refactor renderSelectionStatus, fix when showLabel is false * Add PickerSelectionStatusProps import to PickerScreen and index files * Remove unused setMultiFinalValue from usePickerSelection hook * Remove value from PickerSelectionStatusLabelData * selectedCount moved to usePickerSelection * PickerSelectionStatusBar simplify selectedCount --------- Co-authored-by: Miki Leib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker new
selectionStatusfeature, let the user use 2 types of "Select All" elements -Button, CheckBox.All the draft state management are inside the new
PickerSelectionControlBarcomponent.This is a new feature that meant to replace
renderCustomTopElementlogic (#3465).Snapshot version for testing:
7.39.0-snapshot. 6618Changelog
Picker new
selectionStatusfeature, support "Select All" element.Additional info
None