Docs - LiveCode in table cell - block interaction #3610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
reviewed
Mar 13, 2025
| return ( | ||
| <div className={`${styles.componentItemContainer} ${!showCode ? styles.componentSpotlightStyle : ''}`}> | ||
| {content} | ||
| {interactionBlocker} |
There was a problem hiding this comment.
Because this div is over the content, when the content is the codePreview, the user can't select the code or copy it. It blocks the interactions with it. Perhaps we can just wrap the componentPreview with a div that has pointerEvents: none. Wdyt?
There was a problem hiding this comment.
I tried that but it didn't work, now it is so probably didn't implemented well. Anyways, changed.
Good catch!
…/fix_line_interaction # Conflicts: # docuilib/package.json
nitzanyiz
reviewed
Mar 13, 2025
| <LiveProvider code={code} scope={ReactLiveScope}> | ||
| <LivePreview/> | ||
| </LiveProvider> | ||
| <div style={{pointerEvents: 'none'}}> |
There was a problem hiding this comment.
You could add this as a class in the styles file. Wdyt?
nitzanyiz
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs - LiveCode in table cell - block interaction
Changelog
Docs - LiveCode in table cell - block interaction
Additional info