Skip to content

Internal components - move display name to 'ignore' #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2025

Conversation

Inbal-Tish
Copy link
Collaborator

Description

Internal components - move display name to 'ignore'

Changelog

Internal components - move display name to 'ignore'

Additional info

@Inbal-Tish Inbal-Tish self-assigned this Mar 23, 2025
@Inbal-Tish Inbal-Tish requested a review from M-i-k-e-l March 23, 2025 08:49
@Inbal-Tish
Copy link
Collaborator Author

@M-i-k-e-l Do I need to ignore the Pan components as well? (PanDismissibleView, PanGestureView, PanListenerView, PanningContext, PanResponderView, asPanViewConsumer)

@Inbal-Tish Inbal-Tish assigned M-i-k-e-l and unassigned Inbal-Tish Mar 23, 2025
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we ignoring these components? We're exporting them via src or Incubator.
Regarding the components you've mentioned, I think they'll all be removed in v8, so they can be ignored.

@M-i-k-e-l M-i-k-e-l assigned Inbal-Tish and unassigned M-i-k-e-l Mar 23, 2025
@Inbal-Tish Inbal-Tish enabled auto-merge (squash) March 23, 2025 10:07
@Inbal-Tish Inbal-Tish merged commit d1fce6e into master Mar 23, 2025
1 check passed
@Inbal-Tish Inbal-Tish deleted the infra/clean_components branch March 23, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants