Skip to content

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Mar 13, 2025

When activating a theme, take into account the scenario of child-parent theme relationship.

  • Just one --theme: Activate it
    • If it requires a parent theme, try installing parent from WPORG first, otherwise ask user to provide it
  • Two themes: Check if one is parent and another is child, activate the child
  • Two unrelated themes: Skip activating
  • Three or more themes: Skip activating

@Luc45 Luc45 requested a review from a team March 13, 2025 10:43
@Luc45 Luc45 self-assigned this Mar 13, 2025
Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested great for me, thank you @Luc45!

@zhongruige
Copy link
Contributor

Already approved this but went through and tested the latest changes which worked great for me, thanks so much @Luc45!

@Luc45 Luc45 merged commit 71cbb6a into trunk Mar 14, 2025
17 checks passed
@Luc45 Luc45 deleted the 25-03/activate-theme-with-parent branch March 14, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants