-
Notifications
You must be signed in to change notification settings - Fork 1.3k
task: Remote feature flag gates GutenbergKit plugins #21806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: Remote feature flag gates GutenbergKit plugins #21806
Conversation
Allow remotely controlling the availability of GutenbergKit plugin support.
Generated by 🚫 Danger |
|
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21806-4684ac7 | |
Commit | 4684ac7 | |
Direct Download | wordpress-prototype-build-pr21806-4684ac7.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21806-4684ac7 | |
Commit | 4684ac7 | |
Direct Download | jetpack-prototype-build-pr21806-4684ac7.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21806 +/- ##
=======================================
Coverage 39.32% 39.32%
=======================================
Files 2125 2125
Lines 99871 99871
Branches 15385 15385
=======================================
Hits 39277 39277
Misses 57114 57114
Partials 3480 3480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The associated server code is now deployed, so testing this no longer requires sandbox setup. I removed that note from the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt:2523
- Ensure that automated tests adequately cover the behavior of the new remote feature flag used here for enabling/disabling GutenbergKit plugins.
"plugins" to (gutenbergKitPluginsFeature.isEnabled() && site.isWPCom),
@dcalhoun I need to verify the testing steps. If I'm logged into the app with an Automattic account, and I have "Experimental block editor" enabled, then if I have a plugin that adds third party blocks, typing / in the editor should show those third party blocks? |
@nbradbury currently, this only supports WordPress.com-provided blocks on Simple sites—e.g., Jetpack AI, Tiled Gallery, Image Compare. Atomic and self-hosted, Jetpack-connected sites are not supported. Block types provided by other third-party plugins are not supported. Apologies for not communicating that more clearly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow remotely controlling the availability of GutenbergKit plugin
support. Ref CMM-277.
Related:
To Test:
Experimental block editor
feature flag.logged in user account is an A11n or non-A11n.
Regression Notes
Unlikely for this feature flag change for an experimental feature.
N/A.
Deemed unnecessary for the experimental feature.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):