Skip to content

task: Remote feature flag gates GutenbergKit plugins #21806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Apr 15, 2025

Allow remotely controlling the availability of GutenbergKit plugin
support. Ref CMM-277.

Related:

To Test:

  1. Enable the Experimental block editor feature flag.
  2. Open the editor for a WordPress.com-hosted site.
  3. Verify the expected presence of third-party blocks based on whether the
    logged in user account is an A11n or non-A11n.

Regression Notes

  1. Potential unintended areas of impact
    Unlikely for this feature flag change for an experimental feature.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed unnecessary for the experimental feature.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Allow remotely controlling the availability of GutenbergKit plugin
support.
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 15, 2025

2 Warnings
⚠️ Class GutenbergKitPluginsFeature is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@dcalhoun dcalhoun marked this pull request as ready for review April 15, 2025 15:17
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21806-4684ac7
Commit4684ac7
Direct Downloadwordpress-prototype-build-pr21806-4684ac7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21806-4684ac7
Commit4684ac7
Direct Downloadjetpack-prototype-build-pr21806-4684ac7.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.32%. Comparing base (64f0cea) to head (4684ac7).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21806   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files        2125     2125           
  Lines       99871    99871           
  Branches    15385    15385           
=======================================
  Hits        39277    39277           
  Misses      57114    57114           
  Partials     3480     3480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun dcalhoun enabled auto-merge (squash) April 15, 2025 17:50
@dcalhoun
Copy link
Member Author

The associated server code is now deployed, so testing this no longer requires sandbox setup. I removed that note from the PR description.

@dcalhoun dcalhoun requested a review from Copilot April 15, 2025 19:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt:2523

  • Ensure that automated tests adequately cover the behavior of the new remote feature flag used here for enabling/disabling GutenbergKit plugins.
"plugins" to (gutenbergKitPluginsFeature.isEnabled() && site.isWPCom),

@nbradbury nbradbury self-assigned this Apr 15, 2025
@nbradbury
Copy link
Contributor

@dcalhoun I need to verify the testing steps. If I'm logged into the app with an Automattic account, and I have "Experimental block editor" enabled, then if I have a plugin that adds third party blocks, typing / in the editor should show those third party blocks?

@dcalhoun
Copy link
Member Author

@nbradbury currently, this only supports WordPress.com-provided blocks on Simple sites—e.g., Jetpack AI, Tiled Gallery, Image Compare. Atomic and self-hosted, Jetpack-connected sites are not supported. Block types provided by other third-party plugins are not supported.

Apologies for not communicating that more clearly.

Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dcalhoun dcalhoun merged commit 8b1325b into trunk Apr 16, 2025
31 checks passed
@dcalhoun dcalhoun deleted the task/remote-feature-flag-gates-gutenberg-kit-plugins branch April 16, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Task unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants