Skip to content

task: Remote feature flag gates GutenbergKit #21810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Apr 16, 2025

Augment the existing, user-controlled experimental feature toggle with a remote feature flag that can we used for a phased roll out GutenbergKit regardless of the experimental feature toggle state.

To Test:

A remote feature flag has not yet been deployed on the server, so there should be no changes to the UX.

Regression Notes

  1. Potential unintended areas of impact
    Unlikely for this addition.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed unnecessary for the experimental feature.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Allow remote control of GutenbergKit roll out.
@dcalhoun dcalhoun added [Type] Task Gutenberg Editing and display of Gutenberg blocks. labels Apr 16, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 16, 2025

2 Warnings
⚠️ Class GutenbergKitFeature is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@dcalhoun dcalhoun changed the title task Remote feature flag gates GutenbergKit task: Remote feature flag gates GutenbergKit Apr 16, 2025
@dcalhoun dcalhoun marked this pull request as ready for review April 16, 2025 12:44
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21810-92a416a
Commit92a416a
Direct Downloadjetpack-prototype-build-pr21810-92a416a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21810-92a416a
Commit92a416a
Direct Downloadwordpress-prototype-build-pr21810-92a416a.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.32%. Comparing base (7bc7243) to head (92a416a).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21810   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files        2125     2125           
  Lines       99871    99871           
  Branches    15385    15385           
=======================================
  Hits        39277    39277           
  Misses      57114    57114           
  Partials     3480     3480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun dcalhoun requested a review from nbradbury April 16, 2025 13:30
@nbradbury nbradbury self-assigned this Apr 16, 2025
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good :shipit:

@dcalhoun dcalhoun merged commit ae85198 into trunk Apr 16, 2025
32 of 33 checks passed
@dcalhoun dcalhoun deleted the task/remote-feature-flag-gates-gutenberg-kit branch April 16, 2025 15:09
Copy link

sentry-io bot commented Apr 29, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: ANR for at least 5000 ms. org.wordpress.android.fluxc.persistence.SiteSql... View Issue
  • ‼️ ApplicationNotResponding: ANR org.wordpress.android.models.CategoryModel in d... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Task unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants