-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Full screen reader detail #21816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full screen reader detail #21816
Conversation
Generated by 🚫 Danger |
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/base_manifest.txt 2025-04-21 12:27:29.710627653 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/head_manifest.txt 2025-04-21 12:27:31.830636534 +0000
@@ -598,9 +598,8 @@
<activity
android:name="org.wordpress.android.ui.reader.ReaderPostPagerActivity"
android:excludeFromRecents="true"
- android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
- android:windowSoftInputMode="adjustResize" >
- </activity>
+ android:theme="@style/WordPress.NoActionBar"
+ android:windowSoftInputMode="adjustResize" />
<activity-alias
android:name="org.wordpress.android.WPComPostReaderActivity" Go to https://buildkite.com/automattic/wordpress-android/builds/21655/canvas?sid=0196584c-633c-4333-84d4-81c97e5bbb95, click on the |
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/base_manifest.txt 2025-04-21 12:27:28.675695667 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/head_manifest.txt 2025-04-21 12:27:30.695698304 +0000
@@ -571,9 +571,8 @@
<activity
android:name="org.wordpress.android.ui.reader.ReaderPostPagerActivity"
android:excludeFromRecents="true"
- android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
- android:windowSoftInputMode="adjustResize" >
- </activity>
+ android:theme="@style/WordPress.NoActionBar"
+ android:windowSoftInputMode="adjustResize" />
<activity-alias
android:name="org.wordpress.android.WPComPostReaderActivity" Go to https://buildkite.com/automattic/wordpress-android/builds/21655/canvas?sid=0196584c-633b-4f51-96ee-8c9859f65b83, click on the |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21816-8c16ff4 | |
Commit | 8c16ff4 | |
Direct Download | wordpress-prototype-build-pr21816-8c16ff4.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21816-8c16ff4 | |
Commit | 8c16ff4 | |
Direct Download | jetpack-prototype-build-pr21816-8c16ff4.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21816 +/- ##
=======================================
Coverage 39.32% 39.32%
=======================================
Files 2125 2125
Lines 99871 99871
Branches 15385 15385
=======================================
Hits 39277 39277
Misses 57114 57114
Partials 3480 3480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified Reader detail views on API 35 and 30. 🚀
Fixes CMM-181
This PR adds support for edge-to-edge (full screen) Reader posts. To test:
Note this only works with posts shown in the Reader tab - it doesn't work with posts shown in Notifications. That will be a separate task. Also note that we don't enable edge-to-edge for devices prior to Android 33 because even though they support it, they don't handle it well (ex: system navigation bar keeps popping up).