Skip to content

Full screen reader detail #21816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Apr 18, 2025

Fixes CMM-181

This PR adds support for edge-to-edge (full screen) Reader posts. To test:

  • View a reader post that has a featured image and note the post is edge-to-edge (full screen)
  • View with a post that doesn't have a featured image and note the post is still edge-to-edge
  • Verify that navigation works as expected

Note this only works with posts shown in the Reader tab - it doesn't work with posts shown in Notifications. That will be a separate task. Also note that we don't enable edge-to-edge for devices prior to Android 33 because even though they support it, they don't handle it well (ex: system navigation bar keeps popping up).

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 18, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2025

Project manifest changes for WordPress

The following changes in the WordPress's merged AndroidManifest.xml file were detected (build variant: jetpackVanillaRelease):

--- ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/base_manifest.txt	2025-04-21 12:27:29.710627653 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/head_manifest.txt	2025-04-21 12:27:31.830636534 +0000
@@ -598,9 +598,8 @@
         <activity
             android:name="org.wordpress.android.ui.reader.ReaderPostPagerActivity"
             android:excludeFromRecents="true"
-            android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
-            android:windowSoftInputMode="adjustResize" >
-        </activity>
+            android:theme="@style/WordPress.NoActionBar"
+            android:windowSoftInputMode="adjustResize" />
 
         <activity-alias
             android:name="org.wordpress.android.WPComPostReaderActivity"

Go to https://buildkite.com/automattic/wordpress-android/builds/21655/canvas?sid=0196584c-633c-4333-84d4-81c97e5bbb95, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2025

Project manifest changes for WordPress

The following changes in the WordPress's merged AndroidManifest.xml file were detected (build variant: wordpressVanillaRelease):

--- ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/base_manifest.txt	2025-04-21 12:27:28.675695667 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/head_manifest.txt	2025-04-21 12:27:30.695698304 +0000
@@ -571,9 +571,8 @@
         <activity
             android:name="org.wordpress.android.ui.reader.ReaderPostPagerActivity"
             android:excludeFromRecents="true"
-            android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
-            android:windowSoftInputMode="adjustResize" >
-        </activity>
+            android:theme="@style/WordPress.NoActionBar"
+            android:windowSoftInputMode="adjustResize" />
 
         <activity-alias
             android:name="org.wordpress.android.WPComPostReaderActivity"

Go to https://buildkite.com/automattic/wordpress-android/builds/21655/canvas?sid=0196584c-633b-4f51-96ee-8c9859f65b83, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21816-8c16ff4
Commit8c16ff4
Direct Downloadwordpress-prototype-build-pr21816-8c16ff4.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 18, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21816-8c16ff4
Commit8c16ff4
Direct Downloadjetpack-prototype-build-pr21816-8c16ff4.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.32%. Comparing base (547abec) to head (8c16ff4).
Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
...wordpress/android/ui/main/BaseAppCompatActivity.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21816   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files        2125     2125           
  Lines       99871    99871           
  Branches    15385    15385           
=======================================
  Hits        39277    39277           
  Misses      57114    57114           
  Partials     3480     3480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nbradbury nbradbury requested a review from dcalhoun April 19, 2025 13:39
@nbradbury nbradbury marked this pull request as ready for review April 19, 2025 13:39
@nbradbury nbradbury marked this pull request as draft April 19, 2025 13:59
@nbradbury nbradbury changed the title Edge-to-edge reader detail Full screen reader detail Apr 21, 2025
@nbradbury nbradbury marked this pull request as ready for review April 21, 2025 11:51
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified Reader detail views on API 35 and 30. 🚀

@nbradbury nbradbury merged commit 4fa8c26 into trunk Apr 21, 2025
26 checks passed
@nbradbury nbradbury deleted the issue/CMM-181-edge-to-edge-featured-image branch April 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants