Convert ReaderPostPagerActivity to Kotlin #21822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
…-Android into issue/CMM-288-kotlin-reader-post-pager-activity Conflicts: WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostPagerActivity.java
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21822-1f0f899 | |
| Commit | 1f0f899 | |
| Direct Download | jetpack-prototype-build-pr21822-1f0f899.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21822-1f0f899 | |
| Commit | 1f0f899 | |
| Direct Download | wordpress-prototype-build-pr21822-1f0f899.apk |
adalpari
reviewed
Apr 22, 2025
Comment on lines
+254
to
+255
| viewPager = findViewById(R.id.viewpager) | ||
| progressBar = findViewById(R.id.progress_loading) |
There was a problem hiding this comment.
❓ No need to take any action, but is there any reason why we are not using ViewBindings here?
There was a problem hiding this comment.
That class was created in 2014, before ViewBindings existed, but I'm not sure why it wasn't converted later.
adalpari
reviewed
Apr 22, 2025
| blogIdentifier: String?, | ||
| postIdentifier: String? | ||
| ) { | ||
| if (!TextUtils.isEmpty(blogIdentifier) && !TextUtils.isEmpty(postIdentifier)) { |
There was a problem hiding this comment.
Suggested change
| if (!TextUtils.isEmpty(blogIdentifier) && !TextUtils.isEmpty(postIdentifier)) { | |
| if (!blogIdentifier.isNullOrEmpty() && !postIdentifier.isNullOrEmpty()) { |
Just a nitpick to avoid using Java methods
There was a problem hiding this comment.
Good call! I made that change in 1f0f899
adalpari
approved these changes
Apr 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CMM-288
This PR converts
ReaderPostPagerActivityto Kotlin. No new functionality has been added, but I've resolved all deprecation warnings apart from thePostPagerAdapter. That adapter and related view pager should be updated toViewPager2, but that change will require a separate PR.To test, simply use the Reader and verify that it still works as expected.