-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Tooling] Update Ruby gems #21825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Update Ruby gems #21825
Conversation
Generated by 🚫 Danger |
|
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21825-32dddde | |
Commit | 32dddde | |
Direct Download | wordpress-prototype-build-pr21825-32dddde.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21825-32dddde | |
Commit | 32dddde | |
Direct Download | jetpack-prototype-build-pr21825-32dddde.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any stability concerns @AliSoftware about packages that had major version updates? (e.g. activesupport)
Good catch and good question. From a quick look at the changelog between last |
Update gems to latest version (by just running
bundle update
), especially to fix a security issue with nokogiriAs long as CI is green we should be good to go.
Ref: AINFRA-122