Skip to content
This repository was archived by the owner on Nov 12, 2020. It is now read-only.

Sync with wpandroid #474

Open
wants to merge 1,413 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
1413 commits
Select commit Hold shift + click to select a range
ca41245
Add library media interface method
mkevins Oct 10, 2019
cf38ade
Use EDITOR_PICKER for media library button
mkevins Oct 10, 2019
aa87a60
Merge branch 'develop' into try/fix-media-text-device-picker
mkevins Oct 14, 2019
9416645
Update Aztec ref to v1.3.32
etoledom Oct 15, 2019
5cdc898
Update to Aztec v1.3.33, including gutenberg's ref
hypest Oct 16, 2019
6231d01
Update Aztec ref to the version that reports the crash
daniloercoli Oct 17, 2019
b0f1c39
Add a method to the Aztec Fragment to disable HW accelaration.
daniloercoli Oct 17, 2019
19d7788
Merge remote-tracking branch 'origin/develop' into issue/upgrade-grad…
oguzkocer Oct 17, 2019
5bc6018
Merge remote-tracking branch 'origin/develop' into issue/upgrade-grad…
oguzkocer Oct 17, 2019
ebf382a
Keep a reference to the Fragment view to prevent NPE exceptions
daniloercoli Oct 21, 2019
0b97340
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli Oct 21, 2019
35b6d5a
Update GB hash and Aztec hash
daniloercoli Oct 21, 2019
0765c8d
Update Aztec version to the tagged v1.3.34
daniloercoli Oct 22, 2019
29e5118
First iteration of "add media to editor" refactoring
malinajirka Oct 22, 2019
e444ce7
Merge pull request #10565 from wordpress-mobile/clean-up-after-legacy…
oguzkocer Oct 22, 2019
c2ec96d
Merge pull request #10620 from wordpress-mobile/issue/8828-Aztec-cras…
mchowning Oct 22, 2019
68a4aea
Merge branch 'issue/master-extract-editor-media' into issue/refactor-…
oguzkocer Oct 23, 2019
297e96c
Moves EditorMedia.getVideoThumbnail to EditorMediaUtils
oguzkocer Oct 24, 2019
1315b3d
Add support for giphy and pexel images (#10628)
marecar3 Oct 29, 2019
32c2de0
Adding OnImageFullscreenPreviewListener to GB Fragment for listening …
cameronvoell Oct 30, 2019
bffd289
EditPostActivity implements EditorImagePreviewListener in order to ro…
cameronvoell Oct 30, 2019
5a47206
show stock options only for wp.com or jetpack sites (#10745)
marecar3 Nov 7, 2019
107b8b8
Update generating gutenberg translations to handle plurals
Tug Nov 4, 2019
6b9e27d
Add missing class instance declaration for plurals
Tug Nov 4, 2019
f3aa47c
Merge branch 'master-edit-post-activity-refactor' into issue/10680-ex…
malinajirka Nov 11, 2019
588bd3a
Set postType when initializing Gutenberg
koke Nov 11, 2019
4210ba2
Implement React Native bridge method for making api requests
mchowning Nov 11, 2019
41c0f78
Removed unnecessary media ID not required for current fullscreen impl…
cameronvoell Nov 13, 2019
2d99276
Merge branch 'develop' into master-edit-post-activity-refactor
malinajirka Nov 13, 2019
0d97a7d
Add rule to prevent proguard from obfuscating the main resource file …
Tug Nov 13, 2019
66b1aa5
Move rule from WordPressEditor to WordPress
Tug Nov 13, 2019
206fffb
Fixed crash when trying to reupload nonexistent media.
khaykov Nov 13, 2019
7d1e1e0
Updating fullscreen preview parameter to better name, mediaUrl.
cameronvoell Nov 14, 2019
93f1624
Extract and refactor EditPostActivity.onEditorEvent
malinajirka Nov 14, 2019
6b34a9f
Merge branch 'gutenberg/release-1.17.0' into gutenberg/image-fullscre…
hypest Nov 14, 2019
c182ea4
Put annotations on separate lines
malinajirka Nov 15, 2019
ed17270
Merge remote-tracking branch 'origin/gutenberg/release-1.17.0' into t…
mchowning Nov 15, 2019
9d9e2b0
Merge remote-tracking branch 'origin/gutenberg/release-1.17.0' into g…
Tug Nov 15, 2019
5235de9
Revert "Merge pull request #10719 from wordpress-mobile/gutenberg/fix…
Tug Nov 15, 2019
ff908fb
Script to automate merging strings.xml files into main one
Tug Nov 3, 2019
6ae2c1c
Fix getting english resource for plurals
Tug Nov 16, 2019
8d49cac
Merge remote-tracking branch 'origin/develop' into gutenberg/fix-i18n-2
Tug Nov 18, 2019
1907f61
Catch Resources.NotFoundException when getting translations
Tug Nov 19, 2019
0b8d698
Handle languages that have no plurals
Tug Nov 19, 2019
30fd751
Merge branch 'develop' into try/gutenberg-image-size-networking-native
hypest Nov 19, 2019
157beb0
Merge pull request #10789 from wordpress-mobile/master-edit-post-acti…
planarvoid Nov 19, 2019
59d4622
Merge remote-tracking branch 'origin/develop' into try/gutenberg-imag…
mchowning Nov 19, 2019
7c7181f
Fixed merge conflicts.
khaykov Nov 19, 2019
5999c12
Merge pull request #10791 from wordpress-mobile/issue/10609-fixing-me…
mzorz Nov 20, 2019
606aeb3
Remove support for plurals
Tug Nov 20, 2019
1962eb9
Remove support for plurals
Tug Nov 20, 2019
dadf1cc
Log Resources.NotFoundException with info level instead of error
Tug Nov 20, 2019
595c058
Log Resources.NotFoundException with warning level
Tug Nov 20, 2019
8babf21
Merge branch 'develop' into issue/10793-extract-on-editor-event
malinajirka Nov 25, 2019
0768e1f
Add abstract method for mediaSelectionCancelled
mkevins Nov 27, 2019
3a76476
Implement dummy mediaSelectionCancelled in AztecEditorFragment
mkevins Nov 27, 2019
1cf32c0
Implement mediaSelectionCancelled for gutenberg
mkevins Nov 27, 2019
492df63
Create RNMedia items using mimeType
mkevins Nov 27, 2019
74ada25
Add nonnull check for activity in Gutenberg fragment
planarvoid Nov 27, 2019
cc1664f
Update / add comments for mediaSelectionCancelled method
mkevins Nov 28, 2019
cc72d68
Remove singular versions of appendMedia methods
mkevins Nov 28, 2019
f46e39d
Add log
planarvoid Nov 28, 2019
a254fb1
Merge branch 'develop' into fix/multiple-media-selection-handling
mkevins Nov 29, 2019
057edff
Updated Aztec version to v1.3.35
anitaa1990 Nov 29, 2019
bd439f6
Merge branch 'develop' into issue/10793-extract-on-editor-event
malinajirka Dec 2, 2019
0564f45
Merge remote-tracking branch 'origin/develop' into merge/13.7-into-de…
jkmassel Dec 2, 2019
c994db9
Merge branch 'develop' into fix/multiple-media-selection-handling
mkevins Dec 3, 2019
1f4ef48
Merge branch 'develop' into add/experimental-page-templates
koke Dec 3, 2019
2d8771c
Merge pull request #10874 from wordpress-mobile/anitaa/update-aztec-v…
0nko Dec 9, 2019
51fb587
Gutenberg/activate preformat block (#10868)
marecar3 Dec 9, 2019
026be21
Merge branch 'develop' into try/fix-double-rotation-modal-crash
mkevins Dec 11, 2019
9e4aba4
Observer all changes to the content in Aztec
planarvoid Dec 18, 2019
0ceb592
Use the RN Hermes JS runtime
hypest Dec 20, 2019
9a4cf83
Merge branch 'develop' into add/experimental-page-templates
koke Dec 20, 2019
60abd23
Add TextWatcher to Sources(html) editor view
malinajirka Dec 20, 2019
5103d2f
return current app theme
marecar3 Dec 21, 2019
68c16ae
Update gb-mobile reference
marecar3 Dec 25, 2019
650bc26
Prepare and set default background color for react root view
marecar3 Dec 26, 2019
233fc79
improved text contrast of aztec's title and content
jd-alexander Dec 30, 2019
a44d3ab
Target release version of Aztec
planarvoid Jan 2, 2020
984e1c1
Merge branch 'master_edit_post_activity_refactoring' into feature/con…
planarvoid Jan 3, 2020
3d1d1e9
Update libs/editor/WordPressEditor/src/main/res/values/colors.xml
jd-alexander Jan 7, 2020
d688b89
Update aztec version to v1.3.37
marecar3 Jan 9, 2020
e99c005
Merge branch 'develop' into master_edit_post_activity_refactoring
malinajirka Jan 10, 2020
da3c954
Merge branch 'develop' into gutenberg/dark_mode_integration
marecar3 Jan 13, 2020
ca8f264
Use event instead of callback for preferred color scheme
marecar3 Jan 13, 2020
fa7bf37
fix linter
marecar3 Jan 14, 2020
057441a
Merge branch 'gutenberg/after-1.21.0' into gutenberg/try-rn-hermes
hypest Jan 22, 2020
f7f0e26
Implements OnMediaEditorListener
leandroalonso Jan 27, 2020
4b24549
For network errors, pass http status code back to React Native
mchowning Dec 19, 2019
22e50b7
Use Bundle instead of Map for passing errors
mchowning Dec 20, 2019
0218f06
Introduce edit media listener in GutenbergEditorFragment
ashiagr Jan 30, 2020
80ec2ef
fix typos
akkspros Jan 31, 2020
d251c90
Merge pull request #11200 from wordpress-mobile/issue/11185-link-modu…
malinajirka Feb 3, 2020
9b67570
Merge
marecar3 Feb 6, 2020
142d73b
Remove empty line
marecar3 Feb 6, 2020
7ae1f60
Merge pull request #11212 from akkspros/akkspros
loremattei Feb 7, 2020
0d17555
Updated editor side.
khaykov Feb 8, 2020
43a42de
Applying separate tint to media button.
khaykov Feb 10, 2020
5926582
Overloading horizontal line drawable with listDivider background.
khaykov Feb 10, 2020
8cac101
Updated colors.
khaykov Feb 10, 2020
7ae4355
Merge branch 'develop' into feature/media-editing-basics-phase_one
ashiagr Feb 11, 2020
240621a
Merge branch 'feature/material-theme' into gutenberg/dark_mode_integr…
marecar3 Feb 13, 2020
67e8377
Merge branch 'issue/10646-material-post-settings' of github.com:wordp…
khaykov Feb 13, 2020
f6ff4da
Simplified redundant padding declarations.
khaykov Feb 20, 2020
96d98a4
Add log template event method to EditorFragmentListener interface
mkevins Feb 21, 2020
4aa5b77
Add gutenberg event listener to parameter list
mkevins Feb 21, 2020
37c139e
Implement anonymous gutenberg user event listener
mkevins Feb 21, 2020
b3faca2
Add template apply and preview to EditorFragmentListener interface
mkevins Feb 25, 2020
0c1b5ac
Add template apply and preview methods to gutenberg fragment
mkevins Feb 25, 2020
70ba76d
Use single method interface for logging gutenberg user events
mkevins Feb 25, 2020
036d944
Merge branch 'develop' into feature/media-editing-basics-phase_one
ashiagr Mar 2, 2020
ef34cab
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
khaykov Mar 9, 2020
0414d2b
Merge branch 'feature/material-theme' into gutenberg/dark_mode_integr…
marecar3 Mar 10, 2020
45a071e
Pass is dark mode state when fragment is recreated
marecar3 Mar 12, 2020
6150cdf
Merge branch 'develop' into try/fix-double-rotation-modal-crash
cameronvoell Mar 13, 2020
a3af744
Bump aztec version to 1.3.39
marecar3 Mar 17, 2020
a6f3710
Bumped Editor's material libary version.
khaykov Mar 19, 2020
8f98a5e
Switched to material alert dialog.
khaykov Mar 19, 2020
496217d
Removed unused styles.
khaykov Mar 19, 2020
4e7fb54
Feature/material theme and Dark Theme support (#11469)
khaykov Mar 20, 2020
60206f1
Merge branch 'develop' into gutenberg/integrate_release_1.24.0
marecar3 Mar 20, 2020
ee7dbf2
Revert "Feature/material theme and Dark Theme support (#11469)" (#11486)
khaykov Mar 20, 2020
a27fc17
Merge branch 'develop' into gutenberg/integrate_release_1.24.0
marecar3 Mar 20, 2020
68fe03b
Merge branch 'develop' into feature/media-editing-basics-phase_one
ashiagr Mar 23, 2020
1775985
Removed redundant styles.
khaykov Mar 23, 2020
6f1f107
Merge branch 'develop' into try/fix-double-rotation-modal-crash
cameronvoell Mar 24, 2020
8ba7b41
Merge branch 'develop' into feature/media-editing-basics-phase_one
ashiagr Mar 25, 2020
34c7c0b
Revert "Merge pull request #11362 from wordpress-mobile/gutenberg/iss…
hypest Mar 27, 2020
cf64943
Merge branch 'hotfix/14.4.1' into merge/14.4.1-to-release/14.5
oguzkocer Mar 27, 2020
660b3d8
Merge remote-tracking branch 'origin/develop' into merge/release-14.5…
oguzkocer Mar 27, 2020
f65670f
Updated listener signature
khaykov Mar 30, 2020
8e181e5
Updated headers handling in Aztec
khaykov Mar 30, 2020
b43e15d
Using constant for header name in Aztec.
khaykov Mar 30, 2020
d2d572d
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
khaykov Mar 31, 2020
3c0b52f
Gutenberg/integrate release 1.25.0 with dark mode (#11580)
hypest Apr 3, 2020
c973942
Revert "Gutenberg/integrate release 1.25.0 with dark mode (#11580)"
hypest Apr 6, 2020
bec50d2
Merge branch 'gutenberg/integrate_release_1.25.0-with-dark-mode' into…
hypest Apr 6, 2020
6f71b46
Updated Aztec version to include design changes for Aztec toolbar
anitaa1990 Apr 6, 2020
237d940
Fixed build issue due to Aztec lib changes
anitaa1990 Apr 6, 2020
c8cb4ea
Removed redundant drawables from editor lib
anitaa1990 Apr 6, 2020
855d0d1
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
khaykov Apr 6, 2020
9a135c2
Merge branch 'develop' into woo/aztec-design-changes
anitaa1990 Apr 10, 2020
332d235
Updated aztec release version
anitaa1990 Apr 10, 2020
364f7fd
Merge branch 'develop' into issue/11599-me-gravatar-menu-accessibility
develric Apr 14, 2020
faa6c86
Update media insertion to send caption information.
SergioEstevao Apr 15, 2020
a696112
Fix lint error.
SergioEstevao Apr 20, 2020
d504e1d
Revert "Update media insertion to send caption information."
cameronvoell Apr 20, 2020
1db0566
Merge remote-tracking branch 'origin/develop' into merge/14.7-rc-2-to…
oguzkocer Apr 22, 2020
076d761
Merge branch 'develop' into woo/aztec-design-changes
anitaa1990 Apr 24, 2020
3758c25
Update gutenberg with new Aztec version
mchowning Apr 24, 2020
2d2e52e
Initial implementation of User picking Activity for Gutenberg
mchowning Apr 14, 2020
3491a0b
Pass mentions capability back to RN
mchowning Apr 24, 2020
a573f1b
Merge branch 'feature/media-editing-phase-two' into issue/extract_med…
ashiagr Apr 30, 2020
2a420fa
Merge pull request #11833 from wordpress-mobile/gutenberg/embedded-bu…
hypest May 8, 2020
c255b7b
Add mocked editor theme to provide to Gutenberg
chipsnyder May 15, 2020
57d978d
Remove mock methods and load editor theme from FluxC Store
chipsnyder May 18, 2020
c7e474d
Updated RN aztec and bridge locations for monorepo
cameronvoell May 20, 2020
55467d4
Merge branch 'develop' into gutenberg/issue_331/mention_support
SergioEstevao May 20, 2020
75e5c50
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder May 20, 2020
fb471d7
Provide exception logger for gutenberg
mchowning May 19, 2020
c17bd80
Fetch Editor Theme from store and load in editor
chipsnyder May 21, 2020
27ecc28
Provide breadcrumb logger to Gutenberg
mchowning May 22, 2020
6634aa5
Provide exception logger for gutenberg
mchowning May 19, 2020
e36a354
Provide breadcrumb logger to Gutenberg
mchowning May 22, 2020
f23cf36
Update gutenberg submodule ref
mchowning May 26, 2020
24af922
Gutenberg - Starter Page Templates Tooltip (#11807)
May 26, 2020
0dcef23
Merge remote-tracking branch 'origin/develop' into gutenberg/1.28.1_u…
mchowning May 26, 2020
deeced0
Merge remote-tracking branch 'origin/develop' into merge/14.9-rc-3-to…
mchowning May 28, 2020
87d2526
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder May 28, 2020
5511d03
Update gutenberg
chipsnyder May 28, 2020
3b5393d
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder Jun 3, 2020
1134fa6
Add stub result to GutenbergGlue code
chipsnyder Jun 7, 2020
255a2be
[Gutenberg] Unsupported block fallback (#11919)
marecar3 Jun 8, 2020
3738023
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder Jun 8, 2020
eb1e7ce
Fix lint issues
chipsnyder Jun 8, 2020
f7fa023
Add GIF support to Gutenberg editor
planarvoid Jun 11, 2020
9ad7c48
augmented getVideoFrameFromVideo() in ImageUtils and all related clas…
mzorz Jun 11, 2020
aec7748
Remove unused error message
malinajirka Jun 12, 2020
841d191
Remove unused media type
malinajirka Jun 12, 2020
5a98114
Merge branch 'develop' into issue/12025-media-preview-private-sites
mzorz Jun 12, 2020
f104bd9
Rename append media methods
mkevins Jun 12, 2020
d5baa44
bumped utils to 1.25, needed for passing new auth headers in getVideo…
mzorz Jun 13, 2020
5e4858e
Menu item to get content info
hypest Jun 12, 2020
84493a8
Merge branch 'develop' into rnmobile/try/seamless-media-completion
mkevins Jun 15, 2020
ad2157e
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder Jun 15, 2020
7cdeb30
Update content structure strings.
SergioEstevao Jun 16, 2020
dd357de
Run Toasts in the main UI thread
hypest Jun 16, 2020
d27c492
Merge branch 'develop' into gutenberg/display_content_metrics
SergioEstevao Jun 17, 2020
06793d1
Merge remote-tracking branch 'origin/develop' into rnmobile/issue/174…
chipsnyder Jun 17, 2020
429a5d2
Merge branch 'develop' into rnmobile/try/seamless-media-completion
mkevins Jun 18, 2020
f0e50a0
Merge branch 'develop' into gutenberg/enable-build-from-monorepo
ceyhun Jun 18, 2020
efb2d69
Merge branch 'develop' into feature/add-tenor-to-gutenberg
planarvoid Jun 22, 2020
14c48f1
Set user agent to WebView
marecar3 Jun 22, 2020
66bff99
Fix lint errors
marecar3 Jun 22, 2020
babdcf2
Remove debuggable WebView option
marecar3 Jun 23, 2020
17d4899
Merge pull request #11956 from wordpress-mobile/gutenberg/enable-buil…
mchowning Jun 23, 2020
fc277a2
Merge branch 'develop' into gutenberg/fix-guten-web-auth-issue-after-…
marecar3 Jun 26, 2020
9c2cd86
fix lint errors
marecar3 Jun 26, 2020
b27d83d
Set user-agent to Gutenberg WebView (#12249)
marecar3 Jun 29, 2020
e654d13
Implement unsupported fallback tracks
marecar3 Jun 30, 2020
11f2a95
Fix lint errors
marecar3 Jun 30, 2020
9aa1fd8
Enabling unsupported block editor for sites with the feature active
marecar3 Jul 1, 2020
e4d1b2f
Hide gutenberg mentions feature on Vanilla builds
mchowning Jul 8, 2020
36c113d
Enable unsupported block editor on Atomic sites
marecar3 Jul 9, 2020
0ae8fcf
Merge remote-tracking branch 'origin/gutenberg/release_1.32_integrati…
mchowning Jul 9, 2020
7cd37f7
Build feature flag for MLP
antonis Jul 16, 2020
27eefcc
Use GutenbergProps object
mchowning Jul 9, 2020
723a071
Add Kotlin to editor module
mchowning Jul 13, 2020
ceeecf3
Use builder object for GutenbergProps
mchowning Jul 13, 2020
aae6a89
Make fields in GutenbergPropsBuilder private
mchowning Jul 17, 2020
bdee9c7
Make GutenbergPropsBuilder immutable
mchowning Jul 17, 2020
965ea0a
Reverse config
antonis Jul 22, 2020
09db053
Merge branch 'gutenberg/after_release_1.33.0' into issue/2419-MLPCont…
antonis Jul 22, 2020
5b81019
Updating aztec version to v1.3.44
cameronvoell Jul 31, 2020
7f91699
Merge branch 'develop' into issue/2419-MLPContainer
antonis Aug 4, 2020
49ab5b1
Renamed function parameter
antonis Aug 5, 2020
b92a3db
Send update capabilities events from Android native to JS
marecar3 Aug 8, 2020
321b32c
Merge branch 'develop' into gutenberg/unsupported-block-editor-jetpac…
marecar3 Aug 8, 2020
bac16ff
Adding interface to track user tapping on failed media from editor.
develric Aug 13, 2020
d19ed23
Updating dialog message with error description if available.
develric Aug 13, 2020
dadf117
Renaming method from onFailedToInsertMediaTapped to getErrorMessageFr…
develric Aug 14, 2020
95129c7
Adding save on exiting the editor
mchowning Aug 10, 2020
42f827c
Implement jetpackSsoEnabled
marecar3 Aug 24, 2020
f7e71ac
Refresh capabilities after Save action
marecar3 Aug 25, 2020
18a8668
Pass userId to WebView logic
marecar3 Aug 25, 2020
a1bcc08
fix lint errors
marecar3 Aug 25, 2020
61d016e
Read external resources from gb-mobile
marecar3 Aug 25, 2020
eb414d8
Move jetpack/sso logic to WPAndroid
marecar3 Aug 26, 2020
bcb3f99
Changing media upload error dialog as per design feedback.
develric Aug 30, 2020
9d7dad2
Fixing Linter.
develric Aug 30, 2020
0429b3f
Merge branch 'issue/12325-media-upload-error-codes-sh' into issue/123…
develric Aug 31, 2020
7b7c35e
Fix nux issue on Android side
marecar3 Sep 2, 2020
0feebee
Merge branch 'develop' into gutenberg/unsupported-block-editor-jetpac…
marecar3 Sep 4, 2020
459f054
Merge branch 'develop' into gutenberg/ube-custom-js-scripts
marecar3 Sep 4, 2020
2de8af1
Rename isSitePrivate to isSelfHosted
marecar3 Sep 10, 2020
5636505
Check in one place if arguments are not null
marecar3 Sep 10, 2020
c8f461f
Merge conflicts
marecar3 Sep 12, 2020
a94fa19
Upgrade Gradle to 6
oguzkocer Sep 13, 2020
a883f2a
Remove unused layouts
planarvoid Sep 14, 2020
933c493
Replace ToggleButton with AppCompatToggleButton as parent of RippleTo…
planarvoid Sep 14, 2020
d75fdc8
Merge remote-tracking branch 'origin/develop' into oguz/upgrade-to-gr…
oguzkocer Sep 15, 2020
7c39180
Updates robolectric to v4.4 in order to fix tenor tests
malinajirka Sep 17, 2020
ec374d4
Merge pull request #12948 from wordpress-mobile/update-jdk-to-11
malinajirka Sep 18, 2020
8be4c90
Update compile and target sdk in dependencies
malinajirka Sep 18, 2020
329b8fc
Remove the overlay from the Unsupported Block Editor web view, if Log…
marecar3 Sep 18, 2020
04140c6
Fix lint error
marecar3 Sep 19, 2020
284129d
Merge branch 'develop' into update-target-sdk-to-29
malinajirka Sep 24, 2020
a217dd0
Merge commit '41eb086b1723a99741388d31560275549ff49166' into update-w…
malinajirka Sep 29, 2020
4fbef0f
Remove empty files
malinajirka Oct 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unnecessary media ID not required for current fullscreen impl…
…ementation.
  • Loading branch information
cameronvoell committed Nov 13, 2019
commit 41c0f78d1b1ac54022655c51e3af9fa7bd651b23
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package org.wordpress.android.editor;

public interface EditorImagePreviewListener {
void onImagePreviewRequested(int mediaId, String mediaSource);
void onImagePreviewRequested(String mediaSource);
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public void attachToContainer(ViewGroup viewGroup, OnMediaLibraryButtonListener
OnAuthHeaderRequestedListener onAuthHeaderRequestedListener,
OnImageFullscreenPreviewListener onImageFullscreenPreviewListener) {
mWPAndroidGlueCode.attachToContainer(viewGroup, onMediaLibraryButtonListener, onReattachQueryListener,
onEditorMountListener, onEditorAutosaveListener, onAuthHeaderRequestedListener, onImageFullscreenPreviewListener);
onEditorMountListener, onEditorAutosaveListener, onAuthHeaderRequestedListener,
onImageFullscreenPreviewListener);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ public void run() {
}
},
new OnImageFullscreenPreviewListener() {
@Override public void onImageFullscreenPreviewClicked(int mediaId, String mediaSource) {
mEditorImagePreviewListener.onImagePreviewRequested(mediaId, mediaSource);
@Override public void onImageFullscreenPreviewClicked(String mediaSource) {
mEditorImagePreviewListener.onImagePreviewRequested(mediaSource);
}
});

Expand Down