Skip to content

Split bulk for bulkupsert #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 11, 2025
Merged

Split bulk for bulkupsert #1803

merged 12 commits into from
Jun 11, 2025

Conversation

kprokopenko
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

ResourceExhausted if the bulk greater than max GRPC request size (64M).

Issue Number: #1511

What is the new behavior?

If a bulk request exceeds the maximum size allowed by gRPC, it is split into smaller chunks so that each chunk does not exceed the limit. Each such request is sent separately.

Other information

Copy link

github-actions bot commented Jun 6, 2025

summary

Base version: v3.110.1-0.20250610204446-64cd01d3883e (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.110.0.

@kprokopenko kprokopenko linked an issue Jun 6, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 77.94118% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.60%. Comparing base (64cd01d) to head (60e9c35).

Files with missing lines Patch % Lines
internal/table/client.go 75.00% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1803      +/-   ##
==========================================
- Coverage   70.75%   70.60%   -0.15%     
==========================================
  Files         385      385              
  Lines       40154    40211      +57     
==========================================
- Hits        28409    28392      -17     
- Misses      10583    10638      +55     
- Partials     1162     1181      +19     
Flag Coverage Δ
experiment 70.23% <77.94%> (-0.10%) ⬇️
go-1.21.x 68.85% <77.94%> (-0.12%) ⬇️
go-1.24.x 70.58% <77.94%> (-0.16%) ⬇️
integration 53.40% <64.70%> (-0.54%) ⬇️
macOS 40.31% <45.58%> (+<0.01%) ⬆️
ubuntu 70.60% <77.94%> (-0.15%) ⬇️
unit 40.31% <45.58%> (-0.01%) ⬇️
windows 40.29% <45.58%> (-0.01%) ⬇️
ydb-24.4 52.53% <64.70%> (-0.54%) ⬇️
ydb-25.1 53.34% <64.70%> (-0.50%) ⬇️
ydb-latest 52.82% <64.70%> (-0.54%) ⬇️
ydb-nightly 70.23% <77.94%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@rekby rekby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i have few suggestions

@kprokopenko kprokopenko merged commit 8022130 into master Jun 11, 2025
44 checks passed
@kprokopenko kprokopenko deleted the issue_1511 branch June 11, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Split bulk for bulkupsert
3 participants