Move create_option functionality into it's own method #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main motivation was wanting to override this behaviour without touching any other parts of render_to_response but I think this is also a clearer way to organise the code. Actually - in most cases all I really want to change is the wording of the create text. How would you feel about a get_create_label(self, queryset) method? (example use case - I if someone enters a string with an @ in it I create a new contact with an email address, otherwise I assume it's a name - I'd like to make this behaviour explicit via the create label)
Current coverage is 97.45% (diff: 100%)@@ master #744 diff @@
==========================================
Files 115 115
Lines 1801 1804 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1755 1758 +3
Misses 46 46
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation was wanting to override this behaviour without touching
any other parts of render_to_response but I think this is also a clearer
way to organise the code.
Actually - in most cases all I really want to change is the wording of
the create text. How would you feel about a get_create_label(self,
queryset) method?
(example use case - I if someone enters a string with an @ in it I
create a new contact with an email address, otherwise I assume it's a
name - I'd like to make this behaviour explicit via the create label)