Reorganize Readme #142
Reorganize Readme #142
Conversation
manifests/configmap.yaml
Outdated
| debug_logging: "true" | ||
| dns_name_format: '{cluster}.{team}.staging.{hostedzone}' | ||
| docker_image: registry.opensource.zalan.do/acid/demospilo-10:1.3-p2 | ||
| etcd_host: etcd-client.default.svc.cluster.local:2379 |
There was a problem hiding this comment.
It has to be an empty string, otherwise operator will use build-in default: https://github.com/zalando-incubator/postgres-operator/blob/eba23279c8bfce331c85fd5ca58df204568aceb6/pkg/util/config/config.go#L53
- docker_image versions is p3
| $ make docker push | ||
|
|
||
| You may define the TAG variable to assign an explicit tag to your docker image and the IMAGE to set the image name. | ||
| By default, the tag is computed with `git describe --tags --always --dirty` and the image is `pierone.stups.zalan.do/acid/postgres-operator` |
There was a problem hiding this comment.
Makefile actually contains IMAGE ?= pierone.example.com/acid/postgres-operator
manifests/postgres-operator.yaml
Outdated
| containers: | ||
| - name: postgres-operator | ||
| image: pierone.stups.zalan.do/acid/postgres-operator:workerassgn | ||
| image: registry.opensource.zalan.do/acid/postgres-operator:661b141 |
There was a problem hiding this comment.
Can we just use "latest" tag for that?
|
Changes Unknown when pulling 0dc9ba4 on readme-1 into ** on master**. |
|
Changes Unknown when pulling 453fdbf on readme-1 into ** on master**. |
|
| The last line changes the docker image tag in the manifest to the one the operator image has been built with and removes | ||
| the serviceAccountName definition, as the ServiceAccount is not defined in minikube (neither it should, as one has admin | ||
| permissions there). | ||
| If you perfer to build the image yourself follow up down below. |
There was a problem hiding this comment.
One can add a link here to the build instructions below. Just a minor convenience.
manifests/configmap.yaml
Outdated
| teams_api_url: http://fake-teams-api.default.svc.cluster.local | ||
| workers: "4" | ||
| enable_load_balancer: "true" | ||
| enable_load_balancer: "false" |
There was a problem hiding this comment.
That somehow prevents allocation of external IPs for the operator service on minikube. Are there other settings that need to be changed ?
|
Changes Unknown when pulling 0750419 on readme-1 into ** on master**. |
|
The changes work as of commit |
|
Changes Unknown when pulling ecbd9c0 on readme-1 into ** on master**. |
| LDFLAGS ?= -X=main.version=$(VERSION) | ||
| DOCKERFILE = docker/Dockerfile | ||
| IMAGE ?= pierone.example.com/acid/$(BINARY) | ||
| IMAGE ?= registry.opensource.zalan.do/acid/$(BINARY) |
There was a problem hiding this comment.
we need registry-write in order to push images
There was a problem hiding this comment.
It is overwritten in delivery.yaml, I just wanted to remove the pierone references.
|
👍 |
|
👍 |
|
Changes Unknown when pulling 3fb031e on readme-1 into ** on master**. |
|
👍 |
Working on reorganizing README in favor of getting operator deployed first before focusing on development setup.