Add logical backup for azure #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgrace
requested review from
CyberDem0n,
FxKu,
Jan-M,
idanovinda,
jopadi and
sdudoladov
as code owners
davidspek
reviewed
Sep 22, 2022
|
I would love to see this merged |
Member
|
👍 |
1 similar comment
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for logical backups to be pushed to Azure
In the backup script used to create a logical backup and push to cloud, I had to temporarily write the logical backup to a file in tmp, because Azure's cli cannot by upload data from stdin to a file in a storage account.
There is an extension that can do so, but this extension only works with strings, and fails when you pipe the result of the compress to it. (https://github.com/Azure/azure-cli-extensions/blob/main/src/storage-blob-preview/azext_storage_blob_preview/_help.py#L172)