Remove Patroni leftover objects on cluster deletion. #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Remove only when Patroni is running with Kubernetes support.
|
👍 |
|
👍 |
erthalion
reviewed
Feb 21, 2018
pkg/cluster/cluster.go
Outdated
| for _, suffix := range patroniObjectSuffixes { | ||
| configEndpointName := fmt.Sprintf("%s-%s", c.Name, suffix) | ||
|
|
||
| if ep, err := c.KubeClient.Endpoints(c.Namespace).Get(configEndpointName, metav1.GetOptions{}); err == nil { |
There was a problem hiding this comment.
Why not pass c.KubeClient.Endpoints(c.Namespace) as an argument to this function? In this way we can avoid this code duplication.
There was a problem hiding this comment.
I don't think it is that easy. Endpoint and ConfigMap implement 2 different interfaces and Get functions actually return different types (*v1.Endpoint and *v1.ConfigMap and respectively).
|
👍 |
Avoid code duplication between functions for deleting Endpoints and ConfigMaps
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #241