Disable WAL archiving

[spohner]

This PR adds a disableWALArchiving option in the cluster-spec allowing to override the WAL_S3_BUCKET environment variable and setting it to blank. This will tell Spilo to disable the WAL archiving.

Relevant Spilo code:
https://github.com/zalando/spilo/blob/01a3a99db55c6f4e38a29528fee4c6c7619d719a/postgres-appliance/scripts/configure_spilo.py#L999

https://github.com/zalando/spilo/blob/01a3a99db55c6f4e38a29528fee4c6c7619d719a/postgres-appliance/scripts/configure_spilo.py#L551

https://github.com/zalando/spilo/blob/01a3a99db55c6f4e38a29528fee4c6c7619d719a/postgres-appliance/scripts/configure_spilo.py#L42

[spohner]

Resolves #907

[spohner]

Did a rebase to align with current master. Any comments on this PR by the maintainers?

[FxKu]

@spohner thanks for your contribution. We have this fashion to name our flags "Enable..." and I would like to stick to that. The default should then be true which requires the *bool type to distinguish between false and nil setting. Could you change the CRD validation in the helm chart, too?

[spohner]

Did the changes that you requested, @FxKu. Let me know if there is anymore I can do to get this merged. I can see that the CI is failing due to out-of-date codegen files, but dont know why as it works fine on my machine. Did I miss something?

[FxKu]

Thanks. You have to update the generated code. Simply run ./hack/update-codegen.sh. It should update this file.

[MaxFedotov]

Hello @FxKu, @spohner. Are there any plans to continue with this PR? This looks like a very useful thing.

[derekjanni]

@spohner @FxKu I second that, very useful feature here, would be cool to make it official

[spohner]

Revisited this one and improved it. The previous attempt did not work when editing enableWALArchiving after the cluster was created. Now this should also work. @FxKu

[fourstepper]

Would it be considerably difficult to make it possible to configure backup paths/locations/overall Spill pod environment variables per cluster instead of per-operator?

[Menzorg]

We really need it. Wish it be merged soon.

[machine424]

Unless I'm mistaken, not setting WAL_S3_BUCKET will not enable physical backups as well (https://github.com/zalando/spilo/blob/2.0-p7/postgres-appliance/scripts/configure_spilo.py#L862) so I think enableWALArchiving should be more generic.

[machine424]

And shouldn't we do the same for c.OpConfig.WALGSBucket as well?

[machine424]

How can I help to get this merged? Thanks.

[pawanku2]

Hi , Is this PR merged?

[ibotty]

What's the status on that PR? It looks very useful.

[modzilla99]

Any news?

[FxKu]

With #1794 merged we can close this PR. With the next release you will be able to disable archiving by overwriting WAl location to an empty string.

[FxKu]

Thanks again @spohner for bringing it up. It's def. useful if you can turn off archiving for single clusters, but not all. Hope the new release will help you then.

[spohner]

Great news! Thanks.

[Menzorg]

Thanks a lot!

[mug3n451]

Hi,
i'm trying to disable the WAL in the way described this thread, but even if i set, as a env in the postgresql's cluster manifest, WAL_S3_BUCKET to empty string, the wal at the first installtion is enabled and work.
May i do something wrong?
thanks