define more default values for opConfig CRD #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting internal defaults for the CRD config requires writing coalesce functions that check for empty values. This PR defines defaults for more string fields and adds a coalesce check for
*bool(fields that are true by default). Other data types are not so urgent to fix and maybe we better plan to refactor the configuration anyway.Two more things:
values.yamlis aligned with internal default andvalues.crdfileLogicalBackupS3SSEis set to "" to allow omitting it in the backup script. I removed some comments in the ConfigMap regarding logical backup to make sure sse is set toAES256there, in case people work with this ConfigMap example and expect this settingfixes #905
closes #944