Skip to content

Add eslint & htmllint #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxim-tschumak merged 2 commits into from
Jan 4, 2019
Merged

Add eslint & htmllint #30

maxim-tschumak merged 2 commits into from
Jan 4, 2019

Conversation

@rejas
Copy link
Contributor

@rejas rejas commented Oct 19, 2018

  • added eslint & htmllint with configs based on exisiting source
  • added npm-scripts to call them
  • fixed warnings from linting
  • moved css into own file

@rejas
Copy link
Contributor Author

rejas commented Jan 4, 2019

Hi there, is there no interest in this PR?

@maxim-tschumak
Copy link
Contributor

maxim-tschumak commented Jan 4, 2019

Looks good to me! Thanks for the improvements!

@maxim-tschumak
Copy link
Contributor

maxim-tschumak commented Jan 4, 2019

👍

1 similar comment
@tfrauenstein
Copy link
Member

tfrauenstein commented Jan 4, 2019

👍

@maxim-tschumak maxim-tschumak reopened this Jan 4, 2019
@maxim-tschumak maxim-tschumak merged commit bb9721f into zalando:master Jan 4, 2019
@rejas rejas deleted the cleanups branch January 4, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxim-tschumak maxim-tschumak maxim-tschumak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rejas @maxim-tschumak @tfrauenstein