BLD: don't mask compile errors in setup.py #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip will not display stdio unless setup.py exits with failure. The current technique of attempting to compile, then falling back to installing without extensions doesn't report anything to the user, which can lead to confusion when certain codecs aren't visible. This change just removes the fallback, if users would like to install without extensions, they must pass the (existing) `DISABLE_NUMCODECS_CEXT=1` envvar.
|
I was hit by this issue again - after installing Zarr on a new machine, expected codecs were not available. IMHO, it would be great if this got merged. |
|
Could you please add a changelog entry? Then we can merge. 😄 |
|
Thanks @llllllllll! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip will not display stdio unless setup.py exits with failure. The current
technique of attempting to compile, then falling back to installing without
extensions doesn't report anything to the user, which can lead to confusion when
certain codecs aren't visible.
This change just removes the fallback, if users would like to install without
extensions, they must pass the (existing)
DISABLE_NUMCODECS_CEXT=1envvar.Closes #196
TODO:
tox -e py37passes locallytox -e py27passes locallytox -e docspasses locally