Make Checksum32 an ABC #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 63 63
Lines 2754 2761 +7
=======================================
+ Hits 2753 2760 +7
Misses 1 1
🚀 New features to boost your workflow:
|
jakirkham
reviewed
Apr 7, 2025
| "deprecated" | ||
| ] | ||
| readme = "README.rst" | ||
| dependencies = ["numpy>=1.24", "deprecated", "typing_extensions"] |
There was a problem hiding this comment.
Let's not unwrap this
Edit: To clarify, having this broken out with 1 dependency per line makes it easier to see what was added/removed in the diff. This in turn helps when updating in other package metadata elsewhere (like conda-forge or Linux distros)
|
In the future @dstansby can you please request a review? |
jakirkham
reviewed
Apr 7, 2025
Comment on lines
112
to
113
| class JenkinsLookup3(Checksum32): | ||
| """Bob Jenkin's lookup3 checksum with 32-bit output |
There was a problem hiding this comment.
It appears the checksum method was not added here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's not intended to be used without sub-classing, make
Checksum32an ABC. This also means we can catch any sub-classes that don't implementchecksum()more easily.