Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Added a select modifier closure parameter #5095

Closed
wants to merge 1 commit into from

Conversation

pine3ree
Copy link
Contributor

@pine3ree pine3ree commented Sep 9, 2013

Allows to send more complex queries (for example aggregate fields on joined tables) to the paginator using a simple closure without resorting to DbSelect (parent class) adapter.

Allows to send more complex queries (for example aggregate fields on joined tables) to the paginator using a simple closure without resorting to DbSelect (parent class) adapter.
@samsonasik
Copy link
Contributor

it will conflict with it #4427 that already merged into develop

@pine3ree
Copy link
Contributor Author

pine3ree commented Sep 9, 2013

What about adding a \Closure private property $selectModifier to the adapter and a setter method setSelectModifier(\Closure $selectModifier) to achieve the same result without conflicting with #4427 ?

UPDATE
or even simpler a method modifySelect(\Closure $selectModifier)) which alter the $select property direclty using a closure

@samsonasik
Copy link
Contributor

ping @ralphschindler

@ralphschindler
Copy link
Member

I'm having trouble fully understanding your use case, can you elaborate on what kind of things your closure would be doing?

@pine3ree
Copy link
Contributor Author

@ralphschindler
Never mind, I just needed a way to be able to modify the paginator select. But it turned out that using the DbSelect adapter was a better solution.

i'm closing discussion now.

@pine3ree pine3ree closed this Nov 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants