lib: updatehub: Minor bug fixes #23885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
otavio
force-pushed
the
topic/zephyr-mainline
branch
from
2e5f722 to
1d32ce3
Compare
jukkar
reviewed
Mar 29, 2020
Fix all build warnings. Signed-off-by: Gerson Fernando Budke <[email protected]> Signed-off-by: Otavio Salvador <[email protected]>
The MAX_PAYLOAD_SIZE must reflect the size of COAP_BLOCK_x. This is necessary becase BLOCK size represents max payload size. The current value create inconsistencies for coap lib. The same way, MAX_DOWNLOAD_DATA must allocate sufficient space for MAX_PAYLOAD_SIZE plus all space for coap header etc. Signed-off-by: Gerson Fernando Budke <[email protected]> Signed-off-by: Otavio Salvador <[email protected]>
Extract finish sha256 calc method. Signed-off-by: Gerson Fernando Budke <[email protected]> Signed-off-by: Otavio Salvador <[email protected]>
The current version aborts update when found last transfer block. Now, system checks only at end of coap block transfer total size and install if download is ok. Signed-off-by: Gerson Fernando Budke <[email protected]> Signed-off-by: Otavio Salvador <[email protected]>
After a success image download, UpdateHub needs inform MCUboot that must test new image and then, on success, commit this new image. This add missing upgrade request call step and fixes the upgarde flow. Signed-off-by: Gerson Fernando Budke <[email protected]> Signed-off-by: Otavio Salvador <[email protected]>
This replaces @chtavares592 with @nandojve as he will contributing to it from now on. Signed-off-by: Otavio Salvador <[email protected]>
nandojve
force-pushed
the
topic/zephyr-mainline
branch
from
1d32ce3 to
e43066f
Compare
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs. Tested on FRDM-64K board with latest UpdateHub-CE docker.