lib: coap: Add coap_get_option_int public method #25683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandojve
requested review from
jukkar,
pfalcon,
rlubos,
rveerama1 and
tbursztyka
as code owners
|
CC @otavio |
zephyrbot
added
area: Networking
area: API
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
jukkar
reviewed
May 28, 2020
rlubos
approved these changes
May 28, 2020
otavio
suggested changes
May 28, 2020
nandojve
force-pushed
the
coap_get_option_int
branch
from
187557d to
85d4d98
Compare
otavio
approved these changes
May 29, 2020
nandojve
force-pushed
the
coap_get_option_int
branch
from
85d4d98 to
83dcf1a
Compare
|
@nandojve can you rebase the PR and resolve the conflicts? |
Any CoAP implementation when use at least block transfer or is a server side need access some CoAP options as integer values. This add a method at public interface and defines for block wise operations to avoid code useless code duplication. Signed-off-by: Gerson Fernando Budke <[email protected]>
Clean up and remove macros that uses coap_get_option_int. Signed-off-by: Gerson Fernando Budke <[email protected]>
Small clean-up to use coap_get_option_int. Signed-off-by: Gerson Fernando Budke <[email protected]>
Small clean-up to use coap_get_option_int. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
coap_get_option_int
branch
from
83dcf1a to
d28897c
Compare
|
Rebased, chackpatch is not related with the change 'tests/kernel/lifo/lifo_usage' |
jukkar
approved these changes
Jun 9, 2020
This was referenced Aug 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any CoAP implementation when use at least block transfer or is a server side need access some CoAP options as integer values. This add a method at public interface and defines for block wise operations to avoid code useless code duplication.
This refactor below files:
subsys/net/lib/lwm2m/lwm2m_engine.c
samples/net/sockets/coap_server/src/coap-server.c
The motivation is #25558 that needs same approach already implemented at sample and LWM2M.