Ieee80215 bug fix #31908
Merged
Ieee80215 bug fix #31908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbursztyka
added
bug
jukkar
approved these changes
Feb 3, 2021
tbursztyka
force-pushed
the
ieee80215_bug_fix
branch
2 times, most recently
from
4833bcb to
5f65dee
Compare
added 6 commits
February 3, 2021 18:34
All addressing mode but IEEE802154_ADDR_MODE_NONE should have a valid address. If not, the frame is invalid. Signed-off-by: Tomasz Bursztyka <[email protected]>
Not validating this length could lead to integer underflow and memory corruption. Signed-off-by: Tomasz Bursztyka <[email protected]>
In case the very first fragment holds all the data already. Signed-off-by: Tomasz Bursztyka <[email protected]>
Though ACK frames are not meant to reach L2 (drivers must ensure this never happens), let's "re-enforce" the L2 by dropping them. Signed-off-by: Tomasz Bursztyka <[email protected]>
In case the current packet is the same as the cached one, let's not unreference it while clearing the cache. Signed-off-by: Tomasz Bursztyka <[email protected]>
Bogus fragmented packet could be sent without a FRAG1 fragment and hit reassembly. Let's make sure this does not happen. Signed-off-by: Tomasz Bursztyka <[email protected]>
tbursztyka
force-pushed
the
ieee80215_bug_fix
branch
from
5f65dee to
5bf30ef
Compare
ceolin
approved these changes
Feb 3, 2021
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.14-branch v1.14-branch
# Navigate to the new working tree
cd .worktrees/backport-v1.14-branch
# Create a new branch
git switch --create backport-31908-to-v1.14-branch
# Cherry-pick the merged commits of this pull request and resolve the conflicts
git cherry-pick a980762f70d7048825e6ce9e42ceb6b5f87a5e44~6..a980762f70d7048825e6ce9e42ceb6b5f87a5e44
# Push it to GitHub
git push --set-upstream origin backport-31908-to-v1.14-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.14-branchThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.