[Backport v1.14-branch] Bluetooth: controller: legacy: Fix dev assert in CPR implementation #33759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Will close and reopen to re-trigger CI to check if this failure was one-of: https://buildkite.com/zephyr/zephyr/builds/25274#b9dc55dc-934e-459c-a8a6-abbad89a4671 |
|
Damn, buildkite did not re-trigger, will try a forced push and see... |
cvinayak
force-pushed
the
backport-33272-to-v1.14-branch
branch
from
f962190 to
0c4794a
Compare
cvinayak
changed the title
cvinayak
added
area: Bluetooth
area: Bluetooth Controller
bug
|
Can you rebase now that the doc building is fixed. |
cvinayak
force-pushed
the
backport-33272-to-v1.14-branch
branch
from
0c4794a to
318e703
Compare
|
@galak I get an unrelated ipm driver test failure: https://buildkite.com/zephyr/zephyr/builds/26783 I will try a forced push again. |
Replace a development assertion in the implementation of Connection Parameter Request Procedure with an internal comment and handle transaction violation be ignoring the PDU. Relates to commit dec6140 ("Bluetooth: controller: Fix dev assert in CPR implementation"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
backport-33272-to-v1.14-branch
branch
from
318e703 to
0833f10
Compare
thoh-ot
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a development assertion in the implementation of
Connection Parameter Request Procedure with an internal
comment and handle transaction violation be ignoring the
PDU.
Relates to commit dec6140 ("Bluetooth: controller: Fix
dev assert in CPR implementation").
Signed-off-by: Vinayak Kariappa Chettimada [email protected]