[Backport v2.7-branch] Bluetooth: Mesh: add check for rx buffer overflow in pb adv #45134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is potential buffer overflow in pb adv. If Transaction Continuation PDU comes before Transaction Start PDU the last segment number is set to 0xff. The current implementation has a strictly limited buffer size. It is possible to receive malformed frame with wrong segment number. All segments with number 2 and above will be stored in the memory behind Rx buffer. Signed-off-by: Aleksandr Khromykh <[email protected]> (cherry picked from commit 6896075)
zephyrbot
requested review from
jhedberg,
trond-snekvik,
joerchan and
Vudentz
as code owners
PavelVPV
approved these changes
Apr 26, 2022
alxelax
approved these changes
Apr 26, 2022
|
@alxelax - can you please create an issue for the backport? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6896075 from #45066
Fixes #46705