[Backport v2.7-branch] net: shell: Validate pointer provided with net pkt command #54381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The net_pkt pointer provided to net pkt commands was not validated in any way. Therefore it was fairly easy to crash an application by providing invalid address. This commit adds the pointer validation. It's checked whether the pointer provided belongs to any net_pkt pools known to the net stack, and if the pointer offset within the slab actually points to the beginning of the net_pkt structure. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit e540a98)
zephyrbot
requested review from
rlubos,
tbursztyka and
pfalcon
as code owners
rlubos
approved these changes
Feb 2, 2023
mbolivar-nordic
approved these changes
Feb 3, 2023
|
Can someone please create an issue for this backport? @rlubos? @mbolivar-nordic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e540a98 from #54371
Fixes #55069