Bluetooth: Fix clearing sent_cmd pointer when allocating event buffer #56709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should clear the bt_dev.sent_cmd pointer after using it to allocate a new HCI event buffer in the bt_buf_get_cmd_complete() function. Otherwise, there is a risk of reusing the same stored net_buf for multiple consecutive HCI events in case the controller sents duplicate or invalid event packets. Signed-off-by: Johan Hedberg <[email protected]>
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
asbjornsabo,
hermabe,
jori-nordic,
kruithofa,
Thalley and
theob-pro
alwa-nordic
approved these changes
Apr 11, 2023
Thalley
approved these changes
Apr 11, 2023
carlescufi
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should clear the bt_dev.sent_cmd pointer after using it to allocate a new HCI event buffer in the bt_buf_get_cmd_complete() function. Otherwise, there is a risk of reusing the same stored net_buf for multiple consecutive HCI events in case the controller sents duplicate or invalid event packets.