Skip to content

Conversation

tmon-nordic
Copy link
Contributor

@tmon-nordic tmon-nordic commented Jun 7, 2023

Fail requests if the data does not fit inside buffer.

This commit only adds missing sanity checks but the native posix driver remains broken at the design level. The amount of work to fix the native posix driver in legacy USB stack is deemed too great to be worth it.

Coverity-CID: 195841, GitHub issue #58564
Coverity-CID: 240244, GitHub issue #58570

Fixes #58564
Fixes #58570

Fail requests if the data does not fit inside buffer.

This commit only adds missing sanity checks but the native posix driver
remains broken at the design level. The amount of work to fix the native
posix driver in legacy USB stack is deemed too great to be worth it.

Coverity-CID: 195841, GitHub issue zephyrproject-rtos#58564
Coverity-CID: 240244, GitHub issue zephyrproject-rtos#58570

Signed-off-by: Tomasz Moń <[email protected]>
@tmon-nordic tmon-nordic requested a review from jfischer-no as a code owner June 7, 2023 13:12
@zephyrbot zephyrbot added area: native port Host native arch port (native_sim) area: USB Universal Serial Bus labels Jun 7, 2023
@zephyrbot zephyrbot requested a review from aescolar June 7, 2023 13:13
@aescolar aescolar assigned jfischer-no and unassigned aescolar Jun 7, 2023
@aescolar aescolar requested a review from finikorg June 7, 2023 13:46
Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aescolar aescolar added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Jun 9, 2023
@nashif nashif merged commit 3b14268 into zephyrproject-rtos:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: native port Host native arch port (native_sim) area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix
Projects
None yet
7 participants