[Backport v2.7-branch] Bluetooth: controller: Check minimum sizes of adv PDUs #61694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the maximum sizes were already correctly checked by the code, the minimum sizes of the PDUs were not. This meant that PDUs smaller than the minimum required length (typically 6 bytes for AdvA) were incorrectly forwarded up to the Host. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit 3f0d701)
zephyrbot
requested review from
carlescufi,
cvinayak,
thoh-ot and
kruithofa
as code owners
|
@carlescufi can you add a tracking issue? |
fabiobaltieri
approved these changes
Aug 22, 2023
carlescufi
approved these changes
Aug 23, 2023
cvinayak
approved these changes
Aug 23, 2023
Done |
jgl-meta
approved these changes
Sep 5, 2023
|
Trying to merge this one (with "rebase and merge"), but I'm unable to for some reason. |
Keep trying, the other failing one worked now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3f0d701 from #61651.
Fixes #61784.