Skip to content

Conversation

erwango
Copy link
Member

@erwango erwango commented Aug 24, 2023

In case asserts are deactivated, no check is done on buffers length. Remove asserts and return an error when lengths are not correct.

Check error in case length is set by API user.

gautierg-st
gautierg-st previously approved these changes Aug 24, 2023
Copy link
Contributor

@mrfuchs mrfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits, otherwise LGTM.

In case asserts are deactivated, no check is done on buffers length.
Remove asserts and return an error when lengths are not correct.

Check error in case length is set by API user.

Signed-off-by: Erwan Gouriou <[email protected]>
@erwango erwango requested a review from jhedberg August 30, 2023 08:07
@carlescufi carlescufi merged commit e35974c into zephyrproject-rtos:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants